Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8273408: java.lang.AssertionError: typeSig ERROR on generated class property of record #107

Closed
wants to merge 1 commit into from
Closed

8273408: java.lang.AssertionError: typeSig ERROR on generated class property of record #107

wants to merge 1 commit into from

Conversation

@lgxbslgx
Copy link
Member

@lgxbslgx lgxbslgx commented Sep 28, 2021

Hi all,

I would like to backport this patch about records to jdk17u. The code applies cleanly.

The commit being backported was authored by Guoxiong Li on 17 Sep 2021 and was reviewed by Vicente Romero.

Best Regards,
-- Guoxiong


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8273408: java.lang.AssertionError: typeSig ERROR on generated class property of record

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u pull/107/head:pull/107
$ git checkout pull/107

Update a local copy of the PR:
$ git checkout pull/107
$ git pull https://git.openjdk.java.net/jdk17u pull/107/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 107

View PR using the GUI difftool:
$ git pr show -t 107

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u/pull/107.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 28, 2021

👋 Welcome back gli! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot changed the title Backport e07ab82ee555f27921287a871ba582e0906ad45c 8273408: java.lang.AssertionError: typeSig ERROR on generated class property of record Sep 28, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 28, 2021

This backport pull request has now been updated with issue from the original commit.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Sep 28, 2021

@lgxbslgx This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8273408: java.lang.AssertionError: typeSig ERROR on generated class property of record

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 28, 2021

Webrevs

Loading

@lgxbslgx
Copy link
Member Author

@lgxbslgx lgxbslgx commented Sep 29, 2021

/integrate

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Sep 29, 2021

Going to push as commit dd70512.
Since your change was applied there have been 3 commits pushed to the master branch:

  • c2d1db9: 8273961: jdk/nio/zipfs/ZipFSTester.java fails if file path contains '+' character
  • f48db89: 8272328: java.library.path is not set properly by Windows jpackage app launcher
  • b55ec5b: 8271718: Crash when during color transformation the color profile is replaced

Your commit was automatically rebased without conflicts.

Loading

@openjdk openjdk bot closed this Sep 29, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Sep 29, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 29, 2021

@lgxbslgx Pushed as commit dd70512.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant