Skip to content

8272332: --with-harfbuzz=system doesn't add -lharfbuzz after JDK-8255790 #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

8272332: --with-harfbuzz=system doesn't add -lharfbuzz after JDK-8255790 #11

wants to merge 1 commit into from

Conversation

jerboaa
Copy link
Contributor

@jerboaa jerboaa commented Aug 12, 2021

Hi,

This pull request contains a backport of commit d38b3143 from the openjdk/jdk repository. The issue applies to JDK 17 as well.

The commit being backported was authored by Severin Gehwolf on 12 Aug 2021 and was reviewed by Phil Race.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8272332: --with-harfbuzz=system doesn't add -lharfbuzz after JDK-8255790

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u pull/11/head:pull/11
$ git checkout pull/11

Update a local copy of the PR:
$ git checkout pull/11
$ git pull https://git.openjdk.java.net/jdk17u pull/11/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11

View PR using the GUI difftool:
$ git pr show -t 11

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u/pull/11.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 12, 2021

👋 Welcome back sgehwolf! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport d38b31438dd4730ee2149c02277d60c35b9d7d81 8272332: --with-harfbuzz=system doesn't add -lharfbuzz after JDK-8255790 Aug 12, 2021
@openjdk
Copy link

openjdk bot commented Aug 12, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Aug 12, 2021
@openjdk
Copy link

openjdk bot commented Aug 12, 2021

@jerboaa This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8272332: --with-harfbuzz=system doesn't add -lharfbuzz after JDK-8255790

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 12, 2021
@mlbridge
Copy link

mlbridge bot commented Aug 12, 2021

Webrevs

@jerboaa
Copy link
Contributor Author

jerboaa commented Aug 16, 2021

/integrate

@openjdk
Copy link

openjdk bot commented Aug 16, 2021

Going to push as commit e506cb2.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 9c21382: 8271589: fatal error with variable shift count integer rotate operation.

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Aug 16, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 16, 2021
@openjdk
Copy link

openjdk bot commented Aug 16, 2021

@jerboaa Pushed as commit e506cb2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant