Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8266239: Some duplicated javac command-line options have repeated effect #110

Closed
wants to merge 1 commit into from
Closed

8266239: Some duplicated javac command-line options have repeated effect #110

wants to merge 1 commit into from

Conversation

lgxbslgx
Copy link
Member

@lgxbslgx lgxbslgx commented Sep 28, 2021

Hi all,

I would like to backport this change about javac command option to jdk17u. The code applies cleanly.

The commit being backported was authored by Guoxiong Li on 14 Sep 2021 and was reviewed by Vicente Romero.

Best Regards,
-- Guoxiong


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8266239: Some duplicated javac command-line options have repeated effect

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u pull/110/head:pull/110
$ git checkout pull/110

Update a local copy of the PR:
$ git checkout pull/110
$ git pull https://git.openjdk.java.net/jdk17u pull/110/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 110

View PR using the GUI difftool:
$ git pr show -t 110

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u/pull/110.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 28, 2021

👋 Welcome back gli! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport d05494f98bad351532cdb769c9da6b6e2359b16e 8266239: Some duplicated javac command-line options have repeated effect Sep 28, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 28, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

@openjdk openjdk bot commented Sep 28, 2021

@lgxbslgx This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8266239: Some duplicated javac command-line options have repeated effect

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready rfr labels Sep 28, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 28, 2021

Webrevs

@lgxbslgx
Copy link
Member Author

@lgxbslgx lgxbslgx commented Sep 29, 2021

/csr

@openjdk
Copy link

@openjdk openjdk bot commented Sep 29, 2021

@lgxbslgx the issue for this pull request, JDK-8266239, already has an approved CSR request: JDK-8267955

@lgxbslgx
Copy link
Member Author

@lgxbslgx lgxbslgx commented Sep 30, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Sep 30, 2021

Going to push as commit 91dd244.
Since your change was applied there have been 26 commits pushed to the master branch:

  • c26cd97: 8274326: [macos] Ensure initialisation of sun/lwawt/macosx/CAccessibility in JavaComponentAccessibility.m
  • a9981fb: 8274381: missing CAccessibility definitions in JNI code
  • 20afdfd: 8273278: Support XSLT on GraalVM Native Image--deterministic bytecode generation in XSLT
  • cdd4075: 8273135: java/awt/color/ICC_ColorSpace/MTTransformReplacedProfile.java crashes in liblcms.dylib with NULLSeek+0x7
  • 2586eb0: 8274087: Windows DLL path not set correctly.
  • d6d5a9a: 8271170: Add unit test for what jpackage app launcher puts in the environment
  • a702838: 8270116: Expand ButtonGroupLayoutTraversalTest.java to run in all LaFs, including Aqua on macOS
  • 84f6cb4: 8273498: compiler/c2/Test7179138_1.java timed out
  • c4b3d62: 8273924: ArrayIndexOutOfBoundsException thrown in java.util.JapaneseImperialCalendar.add()
  • f4a0b13: 8271341: Opcode() != Op_If && Opcode() != Op_RangeCheck) || outcnt() == 2 assert failure with Test7179138_1.java
  • ... and 16 more: https://git.openjdk.java.net/jdk17u/compare/4e707bc1fa5a1da5b31b7a94febdd24f8bc3f6c6...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Sep 30, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Sep 30, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 30, 2021

@lgxbslgx Pushed as commit 91dd244.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated
1 participant