Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8273924: ArrayIndexOutOfBoundsException thrown in java.util.JapaneseImperialCalendar.add() #113

Closed
wants to merge 1 commit into from
Closed

Conversation

@satoyoshiki
Copy link

@satoyoshiki satoyoshiki commented Sep 29, 2021


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8273924: ArrayIndexOutOfBoundsException thrown in java.util.JapaneseImperialCalendar.add()

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u pull/113/head:pull/113
$ git checkout pull/113

Update a local copy of the PR:
$ git checkout pull/113
$ git pull https://git.openjdk.java.net/jdk17u pull/113/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 113

View PR using the GUI difftool:
$ git pr show -t 113

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u/pull/113.diff

…mperialCalendar.add()

Backport-of: d39aad92308fbc28bd2de164e331062ebf62da85
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 29, 2021

👋 Welcome back ysatowse! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot changed the title Backport d39aad92308fbc28bd2de164e331062ebf62da85 8273924: ArrayIndexOutOfBoundsException thrown in java.util.JapaneseImperialCalendar.add() Sep 29, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 29, 2021

This backport pull request has now been updated with issue from the original commit.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Sep 29, 2021

@satoyoshiki This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8273924: ArrayIndexOutOfBoundsException thrown in java.util.JapaneseImperialCalendar.add()

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 25 new commits pushed to the master branch:

  • f4a0b13: 8271341: Opcode() != Op_If && Opcode() != Op_RangeCheck) || outcnt() == 2 assert failure with Test7179138_1.java
  • fd81865: 8273359: CI: ciInstanceKlass::get_canonical_holder() doesn't respect instance size
  • 962f393: 8244675: assert(IncrementalInline || (_late_inlines.length() == 0 && !has_mh_late_inlines()))
  • 7298db5: 8223923: C2: Missing interference with mismatched unsafe accesses
  • 6141fcc: 8271600: C2: CheckCastPP which should closely follow Allocate is sunk of a loop
  • 5761056: 8270886: Crash in PhaseIdealLoop::verify_strip_mined_scheduling
  • e4bf9f9: 8271340: Crash PhaseIdealLoop::clone_outer_loop
  • 23fa88b: 8272413: Incorrect num of element count calculation for vector cast
  • 2b393f9: 8272574: C2: assert(false) failed: Bad graph detected in build_loop_late
  • da77acb: 8271954: C2: assert(false) failed: Bad graph detected in build_loop_late
  • ... and 15 more: https://git.openjdk.java.net/jdk17u/compare/9d590fc13b8a82fc3522bed65bb14ce77b1f4d94...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

Loading

@openjdk openjdk bot added the ready label Sep 29, 2021
@satoyoshiki satoyoshiki marked this pull request as ready for review Sep 29, 2021
@openjdk openjdk bot added the rfr label Sep 29, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 29, 2021

Webrevs

Loading

@satoyoshiki
Copy link
Author

@satoyoshiki satoyoshiki commented Sep 29, 2021

/integrate

Loading

@openjdk openjdk bot added the sponsor label Sep 29, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 29, 2021

@satoyoshiki
Your change (at version 261a92c) is now ready to be sponsored by a Committer.

Loading

@coffeys
Copy link
Contributor

@coffeys coffeys commented Sep 29, 2021

/sponsor

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Sep 29, 2021

Going to push as commit c4b3d62.
Since your change was applied there have been 25 commits pushed to the master branch:

  • f4a0b13: 8271341: Opcode() != Op_If && Opcode() != Op_RangeCheck) || outcnt() == 2 assert failure with Test7179138_1.java
  • fd81865: 8273359: CI: ciInstanceKlass::get_canonical_holder() doesn't respect instance size
  • 962f393: 8244675: assert(IncrementalInline || (_late_inlines.length() == 0 && !has_mh_late_inlines()))
  • 7298db5: 8223923: C2: Missing interference with mismatched unsafe accesses
  • 6141fcc: 8271600: C2: CheckCastPP which should closely follow Allocate is sunk of a loop
  • 5761056: 8270886: Crash in PhaseIdealLoop::verify_strip_mined_scheduling
  • e4bf9f9: 8271340: Crash PhaseIdealLoop::clone_outer_loop
  • 23fa88b: 8272413: Incorrect num of element count calculation for vector cast
  • 2b393f9: 8272574: C2: assert(false) failed: Bad graph detected in build_loop_late
  • da77acb: 8271954: C2: assert(false) failed: Bad graph detected in build_loop_late
  • ... and 15 more: https://git.openjdk.java.net/jdk17u/compare/9d590fc13b8a82fc3522bed65bb14ce77b1f4d94...master

Your commit was automatically rebased without conflicts.

Loading

@openjdk openjdk bot closed this Sep 29, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Sep 29, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 29, 2021

@coffeys @satoyoshiki Pushed as commit c4b3d62.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

@openjdk openjdk bot removed the sponsor label Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants