Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8270116: Expand ButtonGroupLayoutTraversalTest.java to run in all LaFs, including Aqua on macOS #117

Closed
wants to merge 1 commit into from

Conversation

rajamah
Copy link
Member

@rajamah rajamah commented Sep 29, 2021

8274389 - Expand ButtonGroupLayoutTraversalTest.java to run in all LaFs, including Aqua on macOS.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8270116: Expand ButtonGroupLayoutTraversalTest.java to run in all LaFs, including Aqua on macOS

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u pull/117/head:pull/117
$ git checkout pull/117

Update a local copy of the PR:
$ git checkout pull/117
$ git pull https://git.openjdk.java.net/jdk17u pull/117/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 117

View PR using the GUI difftool:
$ git pr show -t 117

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u/pull/117.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 29, 2021

👋 Welcome back rajamah! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@rajamah rajamah changed the title backportcb368802815c465f8eef7aa930d6cbb6540d0fa8 Backportcb368802815c465f8eef7aa930d6cbb6540d0fa8 Sep 29, 2021
@rajamah rajamah changed the title Backportcb368802815c465f8eef7aa930d6cbb6540d0fa8 Backport cb368802815c465f8eef7aa930d6cbb6540d0fa8 Sep 29, 2021
@openjdk openjdk bot changed the title Backport cb368802815c465f8eef7aa930d6cbb6540d0fa8 8270116: Expand ButtonGroupLayoutTraversalTest.java to run in all LaFs, including Aqua on macOS Sep 29, 2021
@openjdk
Copy link

openjdk bot commented Sep 29, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Sep 29, 2021

⚠️ @rajamah the full name on your profile does not match the author name in this pull requests' HEAD commit. If this pull request gets integrated then the author name from this pull requests' HEAD commit will be used for the resulting commit. If you wish to push a new commit with a different author name, then please run the following commands in a local repository of your personal fork:

$ git checkout backport-8274389
$ git commit -c user.name='Preferred Full Name' --allow-empty -m 'Update full name'
$ git push

@openjdk
Copy link

openjdk bot commented Sep 29, 2021

@rajamah This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8270116: Expand ButtonGroupLayoutTraversalTest.java to run in all LaFs, including Aqua on macOS

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 19 new commits pushed to the master branch:

  • 84f6cb4: 8273498: compiler/c2/Test7179138_1.java timed out
  • c4b3d62: 8273924: ArrayIndexOutOfBoundsException thrown in java.util.JapaneseImperialCalendar.add()
  • f4a0b13: 8271341: Opcode() != Op_If && Opcode() != Op_RangeCheck) || outcnt() == 2 assert failure with Test7179138_1.java
  • fd81865: 8273359: CI: ciInstanceKlass::get_canonical_holder() doesn't respect instance size
  • 962f393: 8244675: assert(IncrementalInline || (_late_inlines.length() == 0 && !has_mh_late_inlines()))
  • 7298db5: 8223923: C2: Missing interference with mismatched unsafe accesses
  • 6141fcc: 8271600: C2: CheckCastPP which should closely follow Allocate is sunk of a loop
  • 5761056: 8270886: Crash in PhaseIdealLoop::verify_strip_mined_scheduling
  • e4bf9f9: 8271340: Crash PhaseIdealLoop::clone_outer_loop
  • 23fa88b: 8272413: Incorrect num of element count calculation for vector cast
  • ... and 9 more: https://git.openjdk.java.net/jdk17u/compare/4e707bc1fa5a1da5b31b7a94febdd24f8bc3f6c6...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 29, 2021
@mlbridge
Copy link

mlbridge bot commented Sep 29, 2021

Webrevs

@rajamah
Copy link
Member Author

rajamah commented Sep 29, 2021

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Sep 29, 2021
@openjdk
Copy link

openjdk bot commented Sep 29, 2021

@rajamah
Your change (at version d803731) is now ready to be sponsored by a Committer.

@aivanov-jdk
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Sep 29, 2021

Going to push as commit a702838.
Since your change was applied there have been 19 commits pushed to the master branch:

  • 84f6cb4: 8273498: compiler/c2/Test7179138_1.java timed out
  • c4b3d62: 8273924: ArrayIndexOutOfBoundsException thrown in java.util.JapaneseImperialCalendar.add()
  • f4a0b13: 8271341: Opcode() != Op_If && Opcode() != Op_RangeCheck) || outcnt() == 2 assert failure with Test7179138_1.java
  • fd81865: 8273359: CI: ciInstanceKlass::get_canonical_holder() doesn't respect instance size
  • 962f393: 8244675: assert(IncrementalInline || (_late_inlines.length() == 0 && !has_mh_late_inlines()))
  • 7298db5: 8223923: C2: Missing interference with mismatched unsafe accesses
  • 6141fcc: 8271600: C2: CheckCastPP which should closely follow Allocate is sunk of a loop
  • 5761056: 8270886: Crash in PhaseIdealLoop::verify_strip_mined_scheduling
  • e4bf9f9: 8271340: Crash PhaseIdealLoop::clone_outer_loop
  • 23fa88b: 8272413: Incorrect num of element count calculation for vector cast
  • ... and 9 more: https://git.openjdk.java.net/jdk17u/compare/4e707bc1fa5a1da5b31b7a94febdd24f8bc3f6c6...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Sep 29, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Sep 29, 2021
@openjdk
Copy link

openjdk bot commented Sep 29, 2021

@aivanov-jdk @rajamah Pushed as commit a702838.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants