Skip to content

8273887: [macos] java/awt/color/ICC_ColorSpace/MTTransformReplacedProfile.java timed out #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

8273887: [macos] java/awt/color/ICC_ColorSpace/MTTransformReplacedProfile.java timed out #118

wants to merge 1 commit into from

Conversation

mrserb
Copy link
Member

@mrserb mrserb commented Sep 29, 2021

Hi all,

This is update of the the test to make its execution time less, see openjdk/jdk#5587 for additional details.

this pull request contains a backport of commit 1bd11a7f from the openjdk/jdk repository.

The commit being backported was authored by Sergey Bylokhov on 20 Sep 2021 and was reviewed by Alexey Ivanov.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8273887: [macos] java/awt/color/ICC_ColorSpace/MTTransformReplacedProfile.java timed out

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u pull/118/head:pull/118
$ git checkout pull/118

Update a local copy of the PR:
$ git checkout pull/118
$ git pull https://git.openjdk.java.net/jdk17u pull/118/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 118

View PR using the GUI difftool:
$ git pr show -t 118

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u/pull/118.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 29, 2021

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 1bd11a7f2ca433f4aa9c545a20960e0778ec545e 8273887: [macos] java/awt/color/ICC_ColorSpace/MTTransformReplacedProfile.java timed out Sep 29, 2021
@openjdk
Copy link

openjdk bot commented Sep 29, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Sep 29, 2021

@mrserb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8273887: [macos] java/awt/color/ICC_ColorSpace/MTTransformReplacedProfile.java timed out

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 29, 2021
@mrserb mrserb marked this pull request as ready for review September 29, 2021 22:50
@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 29, 2021
@mlbridge
Copy link

mlbridge bot commented Sep 29, 2021

Webrevs

@mrserb
Copy link
Member Author

mrserb commented Sep 30, 2021

/integrate

@openjdk
Copy link

openjdk bot commented Sep 30, 2021

Going to push as commit 845494a.
Since your change was applied there have been 5 commits pushed to the master branch:

  • de6899b: 8273935: (zipfs) Files.getFileAttributeView() throws UOE instead of returning null when view not supported
  • 91dd244: 8266239: Some duplicated javac command-line options have repeated effect
  • c26cd97: 8274326: [macos] Ensure initialisation of sun/lwawt/macosx/CAccessibility in JavaComponentAccessibility.m
  • a9981fb: 8274381: missing CAccessibility definitions in JNI code
  • 20afdfd: 8273278: Support XSLT on GraalVM Native Image--deterministic bytecode generation in XSLT

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Sep 30, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 30, 2021
@openjdk
Copy link

openjdk bot commented Sep 30, 2021

@mrserb Pushed as commit 845494a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant