Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8271589: fatal error with variable shift count integer rotate operation. #12

Closed
wants to merge 1 commit into from
Closed

8271589: fatal error with variable shift count integer rotate operation. #12

wants to merge 1 commit into from

Conversation

@vnkozlov
Copy link
Contributor

@vnkozlov vnkozlov commented Aug 12, 2021

8271589: fatal error with variable shift count integer rotate operation.

Reviewed-by: kvn, sviswanathan


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8271589: fatal error with variable shift count integer rotate operation.

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u pull/12/head:pull/12
$ git checkout pull/12

Update a local copy of the PR:
$ git checkout pull/12
$ git pull https://git.openjdk.java.net/jdk17u pull/12/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12

View PR using the GUI difftool:
$ git pr show -t 12

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u/pull/12.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Aug 12, 2021

👋 Welcome back kvn! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@vnkozlov
Copy link
Contributor Author

@vnkozlov vnkozlov commented Aug 12, 2021

/label backport

Loading

@openjdk openjdk bot changed the title Backport 392fcc9df7e1547672f727e8fdc8de73ffdfe534 8271589: fatal error with variable shift count integer rotate operation. Aug 12, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Aug 12, 2021

This backport pull request has now been updated with issue from the original commit.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Aug 12, 2021

@vnkozlov This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8271589: fatal error with variable shift count integer rotate operation.

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Aug 12, 2021

@vnkozlov The label backport is not a valid label. These labels are valid:

Loading

@mlbridge
Copy link

@mlbridge mlbridge bot commented Aug 12, 2021

Webrevs

Loading

@vnkozlov
Copy link
Contributor Author

@vnkozlov vnkozlov commented Aug 13, 2021

/integrate

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Aug 13, 2021

Going to push as commit 9c21382.

Loading

@openjdk openjdk bot closed this Aug 13, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Aug 13, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Aug 13, 2021

@vnkozlov Pushed as commit 9c21382.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

@vnkozlov vnkozlov deleted the JDK-8271589 branch Aug 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant