Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8274381: missing CAccessibility definitions in JNI code #120

Closed
wants to merge 1 commit into from
Closed

8274381: missing CAccessibility definitions in JNI code #120

wants to merge 1 commit into from

Conversation

savoptik
Copy link
Contributor

@savoptik savoptik commented Sep 30, 2021

It is NOT possible to perform an automatic backport due to a conflict in the file:

  • src/java.desktop/macosx/native/libawt_lwawt/awt/a11y/CommonComponentAccessibility.m

The file is skipped because it lacks the definition of the method that was modified in the original commit.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8274381: missing CAccessibility definitions in JNI code

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u pull/120/head:pull/120
$ git checkout pull/120

Update a local copy of the PR:
$ git checkout pull/120
$ git pull https://git.openjdk.java.net/jdk17u pull/120/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 120

View PR using the GUI difftool:
$ git pr show -t 120

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u/pull/120.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 30, 2021

👋 Welcome back savoptik! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport be4037374520917d5a0ed54eebb3d5d6d100d429 8274381: missing CAccessibility definitions in JNI code Sep 30, 2021
@openjdk
Copy link

openjdk bot commented Sep 30, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Sep 30, 2021
@mlbridge
Copy link

mlbridge bot commented Sep 30, 2021

Webrevs

@savoptik
Copy link
Contributor Author

/reviewer credit @forantar

@openjdk
Copy link

openjdk bot commented Sep 30, 2021

@savoptik
Reviewer ant successfully credited.

@forantar
Copy link
Contributor

Looks correct.

@savoptik
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Sep 30, 2021

@savoptik This PR has not yet been marked as ready for integration.

@openjdk
Copy link

openjdk bot commented Sep 30, 2021

@savoptik This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8274381: missing CAccessibility definitions in JNI code

Reviewed-by: ant

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

  • 20afdfd: 8273278: Support XSLT on GraalVM Native Image--deterministic bytecode generation in XSLT
  • cdd4075: 8273135: java/awt/color/ICC_ColorSpace/MTTransformReplacedProfile.java crashes in liblcms.dylib with NULLSeek+0x7
  • 2586eb0: 8274087: Windows DLL path not set correctly.
  • d6d5a9a: 8271170: Add unit test for what jpackage app launcher puts in the environment
  • a702838: 8270116: Expand ButtonGroupLayoutTraversalTest.java to run in all LaFs, including Aqua on macOS

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@forantar) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 30, 2021
@savoptik
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Sep 30, 2021
@openjdk
Copy link

openjdk bot commented Sep 30, 2021

@savoptik
Your change (at version ef5e695) is now ready to be sponsored by a Committer.

@forantar
Copy link
Contributor

/sponsor

@openjdk
Copy link

openjdk bot commented Sep 30, 2021

Going to push as commit a9981fb.
Since your change was applied there have been 5 commits pushed to the master branch:

  • 20afdfd: 8273278: Support XSLT on GraalVM Native Image--deterministic bytecode generation in XSLT
  • cdd4075: 8273135: java/awt/color/ICC_ColorSpace/MTTransformReplacedProfile.java crashes in liblcms.dylib with NULLSeek+0x7
  • 2586eb0: 8274087: Windows DLL path not set correctly.
  • d6d5a9a: 8271170: Add unit test for what jpackage app launcher puts in the environment
  • a702838: 8270116: Expand ButtonGroupLayoutTraversalTest.java to run in all LaFs, including Aqua on macOS

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Sep 30, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Sep 30, 2021
@openjdk
Copy link

openjdk bot commented Sep 30, 2021

@forantar @savoptik Pushed as commit a9981fb.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

forantar referenced this pull request in openjdk/jdk Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
2 participants