-
Notifications
You must be signed in to change notification settings - Fork 193
8269216: Useless initialization in com/sun/crypto/provider/PBES2Parameters.java #122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back akasko! A progress list of the required criteria for merging this PR into |
|
This backport pull request has now been updated with issue from the original commit. |
|
@akashche This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 1 new commit pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. ➡️ To flag this PR as ready for integration with the above commit message, type |
|
@akashche This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
|
Gentle reminder, it would be great if someone can review this backport. |
|
Clean backports don't need review. Just tag the JBS issue. |
|
@phohensee , thanks for the clarification! Marked the bug for approval. |
|
/integrate |
|
Going to push as commit 229cb35.
Your commit was automatically rebased without conflicts. |
This is a clean backport of a minor cleanup.
Testing:
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u pull/122/head:pull/122$ git checkout pull/122Update a local copy of the PR:
$ git checkout pull/122$ git pull https://git.openjdk.java.net/jdk17u pull/122/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 122View PR using the GUI difftool:
$ git pr show -t 122Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u/pull/122.diff