Skip to content

Conversation

@akashche
Copy link
Contributor

@akashche akashche commented Sep 30, 2021

This is a clean backport of a minor cleanup.

Testing:

  • jdk_security2 passes

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8269216: Useless initialization in com/sun/crypto/provider/PBES2Parameters.java

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u pull/122/head:pull/122
$ git checkout pull/122

Update a local copy of the PR:
$ git checkout pull/122
$ git pull https://git.openjdk.java.net/jdk17u pull/122/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 122

View PR using the GUI difftool:
$ git pr show -t 122

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u/pull/122.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 30, 2021

👋 Welcome back akasko! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport e515873f887ce4071ab4878a4bafca8eea67afea 8269216: Useless initialization in com/sun/crypto/provider/PBES2Parameters.java Sep 30, 2021
@openjdk
Copy link

openjdk bot commented Sep 30, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Sep 30, 2021
@openjdk
Copy link

openjdk bot commented Sep 30, 2021

@akashche This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8269216: Useless initialization in com/sun/crypto/provider/PBES2Parameters.java

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • c26cd97: 8274326: [macos] Ensure initialisation of sun/lwawt/macosx/CAccessibility in JavaComponentAccessibility.m

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 30, 2021
@mlbridge
Copy link

mlbridge bot commented Sep 30, 2021

Webrevs

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 28, 2021

@akashche This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@akashche
Copy link
Contributor Author

akashche commented Nov 1, 2021

Gentle reminder, it would be great if someone can review this backport.

@phohensee
Copy link
Member

Clean backports don't need review. Just tag the JBS issue.

@akashche
Copy link
Contributor Author

akashche commented Nov 3, 2021

@phohensee , thanks for the clarification! Marked the bug for approval.

@akashche
Copy link
Contributor Author

akashche commented Nov 5, 2021

/integrate

@openjdk
Copy link

openjdk bot commented Nov 5, 2021

Going to push as commit 229cb35.
Since your change was applied there have been 131 commits pushed to the master branch:

  • de47488: 8270290: NTLM authentication fails if HEAD request is used
  • 802844a: 8276066: Reset LoopPercentProfileLimit for x86 due to suboptimal performance
  • a0899bf: 8274848: LambdaMetaFactory::metafactory on REF_invokeSpecial impl method has incorrect behavior
  • 583844a: 8275302: unexpected compiler error: cast, intersection types and sealed
  • 0364737: 8276122: Change openjdk project in jcheck to jdk-updates
  • 25bfea6: 8276130: Fix Github Actions of JDK17u to account for update version scheme
  • 22f1513: 8273575: memory leak in appendBootClassPath(), paths must be deallocated
  • 38bfd62: 8273965: some testlibrary_tests/ir_framework tests fail when c1 disabled
  • f0fb814: 8174819: java/nio/file/WatchService/LotsOfEvents.java fails intermittently
  • 08cee6f: 8275104: IR framework does not handle client VM builds correctly
  • ... and 121 more: https://git.openjdk.java.net/jdk17u/compare/a9981fb0ff11965128761ffd1d8fae1c44c7b9fb...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Nov 5, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 5, 2021
@openjdk
Copy link

openjdk bot commented Nov 5, 2021

@akashche Pushed as commit 229cb35.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants