Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8273378: Shenandoah: Remove the remaining uses of os::is_MP #123

Closed
wants to merge 1 commit into from
Closed

8273378: Shenandoah: Remove the remaining uses of os::is_MP #123

wants to merge 1 commit into from

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Sep 30, 2021

Clean backport to keep codebases in sync and avoid surprises when os::is_MP is misbehaving.

Additional testing:

  • hotspot_gc_shenandoah passes

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8273378: Shenandoah: Remove the remaining uses of os::is_MP

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u pull/123/head:pull/123
$ git checkout pull/123

Update a local copy of the PR:
$ git checkout pull/123
$ git pull https://git.openjdk.java.net/jdk17u pull/123/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 123

View PR using the GUI difftool:
$ git pr show -t 123

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u/pull/123.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 30, 2021

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport fc546d6de9a3ed33cf4b04e24e62714332b069cb 8273378: Shenandoah: Remove the remaining uses of os::is_MP Sep 30, 2021
@openjdk
Copy link

openjdk bot commented Sep 30, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Sep 30, 2021

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8273378: Shenandoah: Remove the remaining uses of os::is_MP

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 36 new commits pushed to the master branch:

  • a9981fb: 8274381: missing CAccessibility definitions in JNI code
  • 20afdfd: 8273278: Support XSLT on GraalVM Native Image--deterministic bytecode generation in XSLT
  • cdd4075: 8273135: java/awt/color/ICC_ColorSpace/MTTransformReplacedProfile.java crashes in liblcms.dylib with NULLSeek+0x7
  • 2586eb0: 8274087: Windows DLL path not set correctly.
  • d6d5a9a: 8271170: Add unit test for what jpackage app launcher puts in the environment
  • a702838: 8270116: Expand ButtonGroupLayoutTraversalTest.java to run in all LaFs, including Aqua on macOS
  • 84f6cb4: 8273498: compiler/c2/Test7179138_1.java timed out
  • c4b3d62: 8273924: ArrayIndexOutOfBoundsException thrown in java.util.JapaneseImperialCalendar.add()
  • f4a0b13: 8271341: Opcode() != Op_If && Opcode() != Op_RangeCheck) || outcnt() == 2 assert failure with Test7179138_1.java
  • fd81865: 8273359: CI: ciInstanceKlass::get_canonical_holder() doesn't respect instance size
  • ... and 26 more: https://git.openjdk.java.net/jdk17u/compare/912ae51344e7694be3a9c1f3d60306ffcdd2fe38...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 30, 2021
@mlbridge
Copy link

mlbridge bot commented Sep 30, 2021

Webrevs

@shipilev
Copy link
Member Author

shipilev commented Oct 1, 2021

Got the push approval.

/integrate

@openjdk
Copy link

openjdk bot commented Oct 1, 2021

Going to push as commit c136c18.
Since your change was applied there have been 40 commits pushed to the master branch:

  • 845494a: 8273887: [macos] java/awt/color/ICC_ColorSpace/MTTransformReplacedProfile.java timed out
  • de6899b: 8273935: (zipfs) Files.getFileAttributeView() throws UOE instead of returning null when view not supported
  • 91dd244: 8266239: Some duplicated javac command-line options have repeated effect
  • c26cd97: 8274326: [macos] Ensure initialisation of sun/lwawt/macosx/CAccessibility in JavaComponentAccessibility.m
  • a9981fb: 8274381: missing CAccessibility definitions in JNI code
  • 20afdfd: 8273278: Support XSLT on GraalVM Native Image--deterministic bytecode generation in XSLT
  • cdd4075: 8273135: java/awt/color/ICC_ColorSpace/MTTransformReplacedProfile.java crashes in liblcms.dylib with NULLSeek+0x7
  • 2586eb0: 8274087: Windows DLL path not set correctly.
  • d6d5a9a: 8271170: Add unit test for what jpackage app launcher puts in the environment
  • a702838: 8270116: Expand ButtonGroupLayoutTraversalTest.java to run in all LaFs, including Aqua on macOS
  • ... and 30 more: https://git.openjdk.java.net/jdk17u/compare/912ae51344e7694be3a9c1f3d60306ffcdd2fe38...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Oct 1, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 1, 2021
@openjdk
Copy link

openjdk bot commented Oct 1, 2021

@shipilev Pushed as commit c136c18.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shipilev shipilev deleted the JDK-8273378 branch October 1, 2021 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant