-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8268464: Remove dependancy of TestHttpsServer, HttpTransaction, HttpCallback from open/test/jdk/sun/net/www/protocol/https/ tests #129
Conversation
👋 Welcome back akasko! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
@akashche This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. ➡️ To flag this PR as ready for integration with the above commit message, type |
@akashche This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
Gentle reminder, it would be great if someone can review this backport. |
Marked the bug for approval. |
/integrate |
Going to push as commit 4003db8.
Your commit was automatically rebased without conflicts. |
Clean backport of a tests cleanup, change is test-only.
Testing: ran jtreg:sun/net/www/protocol/https to check that TestHttpsServer is not used there.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u pull/129/head:pull/129
$ git checkout pull/129
Update a local copy of the PR:
$ git checkout pull/129
$ git pull https://git.openjdk.java.net/jdk17u pull/129/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 129
View PR using the GUI difftool:
$ git pr show -t 129
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u/pull/129.diff