Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8225083: Remove Google certificate that is expiring in December 2021 #13

Closed
wants to merge 1 commit into from
Closed

8225083: Remove Google certificate that is expiring in December 2021 #13

wants to merge 1 commit into from

Conversation

rhalade
Copy link
Member

@rhalade rhalade commented Aug 17, 2021

Hi all,

This pull request contains a clean backport of commit 1cbf41a8 from the openjdk/jdk repository.

The commit being backported was authored by Rajan Halade on 17 Aug 2021 and was reviewed by Xue-Lei Andrew Fan and Sean Mullan.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8225083: Remove Google certificate that is expiring in December 2021

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u pull/13/head:pull/13
$ git checkout pull/13

Update a local copy of the PR:
$ git checkout pull/13
$ git pull https://git.openjdk.java.net/jdk17u pull/13/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 13

View PR using the GUI difftool:
$ git pr show -t 13

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u/pull/13.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 17, 2021

👋 Welcome back rhalade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 1cbf41a87b153c010c51fdbae832e00314422193 8225083: Remove Google certificate that is expiring in December 2021 Aug 17, 2021
@openjdk
Copy link

openjdk bot commented Aug 17, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Aug 17, 2021

@rhalade This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8225083: Remove Google certificate that is expiring in December 2021

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 8 new commits pushed to the master branch:

  • 790d9a9: 8272131: PhaseMacroExpand::generate_slow_arraycopy crash when clone null CallProjections.fallthrough_ioproj
  • 8a20dfe: 8271203: C2: assert(iff->Opcode() == Op_If || iff->Opcode() == Op_CountedLoopEnd || iff->Opcode() == Op_RangeCheck) failed: Check this code when new subtype is added
  • 66bd0d5: 8271276: C2: Wrong JVM state used for receiver null check
  • 32f026a: 8268963: [IR Framework] Some default regexes matching on PrintOptoAssembly in IRNode.java do not work on all platforms
  • 9489ab7: 8271925: ZGC: Arraycopy stub passes invalid oop to load barrier
  • 90341db: 8268019: C2: assert(no_dead_loop) failed: dead loop detected
  • 52c3e7d: 8270098: ZGC: ZBarrierSetC2::clone_at_expansion fails with "Guard against surprises" assert
  • cb7e311: 8261088: Repeatable annotations without @target cannot have containers that target module declarations

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 17, 2021
@mlbridge
Copy link

mlbridge bot commented Aug 17, 2021

Webrevs

@rhalade
Copy link
Member Author

rhalade commented Aug 18, 2021

/integrate

@openjdk
Copy link

openjdk bot commented Aug 18, 2021

Going to push as commit 551354e.
Since your change was applied there have been 9 commits pushed to the master branch:

  • f002833: 8272124: Cgroup v1 initialization causes NullPointerException when cgroup path contains colon
  • 790d9a9: 8272131: PhaseMacroExpand::generate_slow_arraycopy crash when clone null CallProjections.fallthrough_ioproj
  • 8a20dfe: 8271203: C2: assert(iff->Opcode() == Op_If || iff->Opcode() == Op_CountedLoopEnd || iff->Opcode() == Op_RangeCheck) failed: Check this code when new subtype is added
  • 66bd0d5: 8271276: C2: Wrong JVM state used for receiver null check
  • 32f026a: 8268963: [IR Framework] Some default regexes matching on PrintOptoAssembly in IRNode.java do not work on all platforms
  • 9489ab7: 8271925: ZGC: Arraycopy stub passes invalid oop to load barrier
  • 90341db: 8268019: C2: assert(no_dead_loop) failed: dead loop detected
  • 52c3e7d: 8270098: ZGC: ZBarrierSetC2::clone_at_expansion fails with "Guard against surprises" assert
  • cb7e311: 8261088: Repeatable annotations without @target cannot have containers that target module declarations

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Aug 18, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 18, 2021
@openjdk
Copy link

openjdk bot commented Aug 18, 2021

@rhalade Pushed as commit 551354e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant