-
Notifications
You must be signed in to change notification settings - Fork 193
8273807: Zero: Drop incorrect test block from compiler/startup/NumCompilerThreadsCheck.java #132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back shade! A progress list of the required criteria for merging this PR into |
|
This backport pull request has now been updated with issue from the original commit. |
|
@shipilev This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
|
Got the push approval. The GHA test failures are not related and fixed separately. /integrate |
|
Going to push as commit 88d2053.
Your commit was automatically rebased without conflicts. |
Another Zero testing fix.
Additional testing:
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u pull/132/head:pull/132$ git checkout pull/132Update a local copy of the PR:
$ git checkout pull/132$ git pull https://git.openjdk.java.net/jdk17u pull/132/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 132View PR using the GUI difftool:
$ git pr show -t 132Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u/pull/132.diff