Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8273807: Zero: Drop incorrect test block from compiler/startup/NumCompilerThreadsCheck.java #132

Closed
wants to merge 1 commit into from

Conversation

@shipilev
Copy link
Contributor

@shipilev shipilev commented Oct 1, 2021

Another Zero testing fix.

Additional testing:

  • Affected test runs Zero properly now

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8273807: Zero: Drop incorrect test block from compiler/startup/NumCompilerThreadsCheck.java

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u pull/132/head:pull/132
$ git checkout pull/132

Update a local copy of the PR:
$ git checkout pull/132
$ git pull https://git.openjdk.java.net/jdk17u pull/132/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 132

View PR using the GUI difftool:
$ git pr show -t 132

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u/pull/132.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 1, 2021

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot changed the title Backport 1c5de8b86b038f5d5c313c504a8868e36fc80bde 8273807: Zero: Drop incorrect test block from compiler/startup/NumCompilerThreadsCheck.java Oct 1, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 1, 2021

This backport pull request has now been updated with issue from the original commit.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Oct 1, 2021

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8273807: Zero: Drop incorrect test block from compiler/startup/NumCompilerThreadsCheck.java

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 1, 2021

Webrevs

Loading

@shipilev
Copy link
Contributor Author

@shipilev shipilev commented Oct 4, 2021

Got the push approval. The GHA test failures are not related and fixed separately.

/integrate

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Oct 4, 2021

Going to push as commit 88d2053.
Since your change was applied there have been 10 commits pushed to the master branch:

  • 94ec379: 8273335: compiler/blackhole tests should not run with interpreter-only VMs
  • 3cc4dc2: 8273483: Zero: Clear pending JNI exception check in native method handler
  • 9c61789: 8273440: Zero: Disable runtime/Unsafe/InternalErrorTest.java
  • 82788f2: 8273333: Zero should warn about unimplemented -XX:+LogTouchedMethods
  • d59e97d: 8273606: Zero: SPARC64 build fails with si_band type mismatch
  • b5d4060: 8273373: Zero: Cannot invoke JVM in primordial threads on Zero
  • c5446c1: 8274435: EXCEPTION_ACCESS_VIOLATION in BFSClosure::closure_impl
  • 32678f7: 8272914: Create hotspot:tier2 and hotspot:tier3 test groups
  • 58487fb: 8273361: InfoOptsTest is failing in tier1
  • 2490386: 8271287: jdk/jshell/CommandCompletionTest.java fails with "lists don't have the same size expected"

Your commit was automatically rebased without conflicts.

Loading

@openjdk openjdk bot closed this Oct 4, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Oct 4, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 4, 2021

@shipilev Pushed as commit 88d2053.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

@shipilev shipilev deleted the JDK-8273807 branch Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant