Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8269637: javax/swing/JFileChooser/FileSystemView/SystemIconTest.java fails on windows #135

Closed
wants to merge 1 commit into from
Closed

Conversation

@akashche
Copy link
Contributor

@akashche akashche commented Oct 1, 2021

Clean backport of a Windows-specific fix. Testing: checked that enabled test passes on Windows, was unable to reproduce test failure without the fix.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8269637: javax/swing/JFileChooser/FileSystemView/SystemIconTest.java fails on windows

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u pull/135/head:pull/135
$ git checkout pull/135

Update a local copy of the PR:
$ git checkout pull/135
$ git pull https://git.openjdk.java.net/jdk17u pull/135/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 135

View PR using the GUI difftool:
$ git pr show -t 135

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u/pull/135.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 1, 2021

👋 Welcome back akasko! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot changed the title Backport a033866d786507db69ab75643684e617fd1f4ba2 8269637: javax/swing/JFileChooser/FileSystemView/SystemIconTest.java fails on windows Oct 1, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 1, 2021

This backport pull request has now been updated with issue from the original commit.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Oct 1, 2021

@akashche This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8269637: javax/swing/JFileChooser/FileSystemView/SystemIconTest.java fails on windows

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

Loading

@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 1, 2021

Webrevs

Loading

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 29, 2021

@akashche This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

Loading

@akashche
Copy link
Contributor Author

@akashche akashche commented Nov 1, 2021

Gentle reminder, it would be great if someone can review this backport.

Loading

@phohensee
Copy link
Member

@phohensee phohensee commented Nov 3, 2021

Clean backports don't need review. Just tag the JBS issue.

Loading

@akashche
Copy link
Contributor Author

@akashche akashche commented Nov 3, 2021

Marked the bug for approval.

Loading

@akashche
Copy link
Contributor Author

@akashche akashche commented Nov 5, 2021

/integrate

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Nov 5, 2021

Going to push as commit 00fed20.
Since your change was applied there have been 129 commits pushed to the master branch:

  • 9f3c840: 8268361: Fix the infinite loop in next_line
  • 4003db8: 8268464: Remove dependancy of TestHttpsServer, HttpTransaction, HttpCallback from open/test/jdk/sun/net/www/protocol/https/ tests
  • 229cb35: 8269216: Useless initialization in com/sun/crypto/provider/PBES2Parameters.java
  • de47488: 8270290: NTLM authentication fails if HEAD request is used
  • 802844a: 8276066: Reset LoopPercentProfileLimit for x86 due to suboptimal performance
  • a0899bf: 8274848: LambdaMetaFactory::metafactory on REF_invokeSpecial impl method has incorrect behavior
  • 583844a: 8275302: unexpected compiler error: cast, intersection types and sealed
  • 0364737: 8276122: Change openjdk project in jcheck to jdk-updates
  • 25bfea6: 8276130: Fix Github Actions of JDK17u to account for update version scheme
  • 22f1513: 8273575: memory leak in appendBootClassPath(), paths must be deallocated
  • ... and 119 more: https://git.openjdk.java.net/jdk17u/compare/c136c188b519aa315985c9dd0bbe9fedbf182175...master

Your commit was automatically rebased without conflicts.

Loading

@openjdk openjdk bot closed this Nov 5, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Nov 5, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Nov 5, 2021

@akashche Pushed as commit 00fed20.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants