New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8269637: javax/swing/JFileChooser/FileSystemView/SystemIconTest.java fails on windows #135
Conversation
|
This backport pull request has now been updated with issue from the original commit. |
@akashche This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the As you do not have Committer status in this project an existing Committer must agree to sponsor your change.
|
@akashche This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
Gentle reminder, it would be great if someone can review this backport. |
Clean backports don't need review. Just tag the JBS issue. |
Marked the bug for approval. |
/integrate |
Going to push as commit 00fed20.
Your commit was automatically rebased without conflicts. |
Clean backport of a Windows-specific fix. Testing: checked that enabled test passes on Windows, was unable to reproduce test failure without the fix.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u pull/135/head:pull/135
$ git checkout pull/135
Update a local copy of the PR:
$ git checkout pull/135
$ git pull https://git.openjdk.java.net/jdk17u pull/135/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 135
View PR using the GUI difftool:
$ git pr show -t 135
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u/pull/135.diff