Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8261088: Repeatable annotations without @Target cannot have containers that target module declarations #14

Closed
wants to merge 1 commit into from
Closed

Conversation

@jddarcy
Copy link
Member

@jddarcy jddarcy commented Aug 17, 2021


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8261088: Repeatable annotations without @target cannot have containers that target module declarations

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u pull/14/head:pull/14
$ git checkout pull/14

Update a local copy of the PR:
$ git checkout pull/14
$ git pull https://git.openjdk.java.net/jdk17u pull/14/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14

View PR using the GUI difftool:
$ git pr show -t 14

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u/pull/14.diff

@jddarcy
Copy link
Member Author

@jddarcy jddarcy commented Aug 17, 2021

/sponsor

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Aug 17, 2021

👋 Welcome back darcy! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 60c11fef006124e6c2be6d958c78dc344bb777d5 8261088: Repeatable annotations without @Target cannot have containers that target module declarations Aug 17, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Aug 17, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

@openjdk openjdk bot commented Aug 17, 2021

@jddarcy This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8261088: Repeatable annotations without @Target cannot have containers that target module declarations

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • e506cb2: 8272332: --with-harfbuzz=system doesn't add -lharfbuzz after JDK-8255790
  • 9c21382: 8271589: fatal error with variable shift count integer rotate operation.

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk
Copy link

@openjdk openjdk bot commented Aug 17, 2021

@jddarcy This change does not need sponsoring - the author is allowed to integrate it.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Aug 17, 2021

Webrevs

@jddarcy
Copy link
Member Author

@jddarcy jddarcy commented Aug 17, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Aug 17, 2021

Going to push as commit cb7e311.
Since your change was applied there have been 2 commits pushed to the master branch:

  • e506cb2: 8272332: --with-harfbuzz=system doesn't add -lharfbuzz after JDK-8255790
  • 9c21382: 8271589: fatal error with variable shift count integer rotate operation.

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Aug 17, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Aug 17, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Aug 17, 2021

@jddarcy Pushed as commit cb7e311.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant