Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8273373: Zero: Cannot invoke JVM in primordial threads on Zero #141

Closed
wants to merge 1 commit into from
Closed

8273373: Zero: Cannot invoke JVM in primordial threads on Zero #141

wants to merge 1 commit into from

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Oct 1, 2021

This fixes gtests with Zero.

Additional testing:

  • gtests now run fine with Linux x86_64 Zero

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8273373: Zero: Cannot invoke JVM in primordial threads on Zero

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u pull/141/head:pull/141
$ git checkout pull/141

Update a local copy of the PR:
$ git checkout pull/141
$ git pull https://git.openjdk.java.net/jdk17u pull/141/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 141

View PR using the GUI difftool:
$ git pr show -t 141

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u/pull/141.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 1, 2021

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 0f31d0fb2c0d5db305e75e1d61bcc44de3e77839 8273373: Zero: Cannot invoke JVM in primordial threads on Zero Oct 1, 2021
@openjdk
Copy link

openjdk bot commented Oct 1, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Oct 1, 2021

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8273373: Zero: Cannot invoke JVM in primordial threads on Zero

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 2490386: 8271287: jdk/jshell/CommandCompletionTest.java fails with "lists don't have the same size expected"

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 1, 2021
@mlbridge
Copy link

mlbridge bot commented Oct 1, 2021

Webrevs

@shipilev
Copy link
Member Author

shipilev commented Oct 4, 2021

Got push approval.

/integrate

@openjdk
Copy link

openjdk bot commented Oct 4, 2021

Going to push as commit b5d4060.
Since your change was applied there have been 4 commits pushed to the master branch:

  • c5446c1: 8274435: EXCEPTION_ACCESS_VIOLATION in BFSClosure::closure_impl
  • 32678f7: 8272914: Create hotspot:tier2 and hotspot:tier3 test groups
  • 58487fb: 8273361: InfoOptsTest is failing in tier1
  • 2490386: 8271287: jdk/jshell/CommandCompletionTest.java fails with "lists don't have the same size expected"

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Oct 4, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 4, 2021
@openjdk
Copy link

openjdk bot commented Oct 4, 2021

@shipilev Pushed as commit b5d4060.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shipilev shipilev deleted the JDK-8273373 branch October 5, 2021 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant