Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8273487: Zero: Handle "zero" variant in runtime tests #147

Closed
wants to merge 1 commit into from
Closed

8273487: Zero: Handle "zero" variant in runtime tests #147

wants to merge 1 commit into from

Conversation

@shipilev
Copy link
Contributor

@shipilev shipilev commented Oct 4, 2021

Clean backport to fix a few other tier1 tests for Zero.

Addtional testing:

  • Linux x86_64 Zero affected tests (StackGap, StackGuardPages, TestTLS) now pass

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8273487: Zero: Handle "zero" variant in runtime tests

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u pull/147/head:pull/147
$ git checkout pull/147

Update a local copy of the PR:
$ git checkout pull/147
$ git pull https://git.openjdk.java.net/jdk17u pull/147/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 147

View PR using the GUI difftool:
$ git pr show -t 147

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u/pull/147.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 4, 2021

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot changed the title Backport 8c16f485b341ee3071c91df39dfb9ba8b9caa44d 8273487: Zero: Handle "zero" variant in runtime tests Oct 4, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 4, 2021

This backport pull request has now been updated with issue from the original commit.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Oct 4, 2021

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8273487: Zero: Handle "zero" variant in runtime tests

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 4, 2021

Webrevs

Loading

@shipilev
Copy link
Contributor Author

@shipilev shipilev commented Oct 5, 2021

Got the push approval.

/integrate

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Oct 5, 2021

Going to push as commit 09370c3.
Since your change was applied there have been 3 commits pushed to the master branch:

  • 328358a: 8274349: ForkJoinPool.commonPool() does not work with 1 CPU
  • 5e90da9: 8274083: Update testing docs to mention tiered testing
  • 973911e: 8273314: Add tier4 test groups

Your commit was automatically rebased without conflicts.

Loading

@openjdk openjdk bot closed this Oct 5, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Oct 5, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 5, 2021

@shipilev Pushed as commit 09370c3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

@shipilev shipilev deleted the JDK-8273487 branch Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant