Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8272703: StressSeed should be set via FLAG_SET_ERGO #149

Closed
wants to merge 1 commit into from
Closed

8272703: StressSeed should be set via FLAG_SET_ERGO #149

wants to merge 1 commit into from

Conversation

shipilev
Copy link
Contributor

@shipilev shipilev commented Oct 4, 2021

Clean backport to improve compiler testing.

Additional testing:

  • Eyeballing StressSeed is printed in hs_err after the artificial crash

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8272703: StressSeed should be set via FLAG_SET_ERGO

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u pull/149/head:pull/149
$ git checkout pull/149

Update a local copy of the PR:
$ git checkout pull/149
$ git pull https://git.openjdk.java.net/jdk17u pull/149/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 149

View PR using the GUI difftool:
$ git pr show -t 149

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u/pull/149.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 4, 2021

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 66ce09f51eb37029c8ba67a70f8c90a307dae1eb 8272703: StressSeed should be set via FLAG_SET_ERGO Oct 4, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 4, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

@openjdk openjdk bot commented Oct 4, 2021

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8272703: StressSeed should be set via FLAG_SET_ERGO

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 5e90da9: 8274083: Update testing docs to mention tiered testing
  • 973911e: 8273314: Add tier4 test groups

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready rfr labels Oct 4, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 4, 2021

Webrevs

@shipilev
Copy link
Contributor Author

@shipilev shipilev commented Oct 5, 2021

@tobiasholenstein, you good with this to go in 17u?

@tobiasholenstein
Copy link

@tobiasholenstein tobiasholenstein commented Oct 5, 2021

@tobiasholenstein, you good with this to go in 17u?

Sure, go ahead!

@shipilev
Copy link
Contributor Author

@shipilev shipilev commented Oct 5, 2021

Got the push approval as well.

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Oct 5, 2021

Going to push as commit f886e85.
Since your change was applied there have been 5 commits pushed to the master branch:

  • 894767d: 8273376: Zero: Disable vtable/itableStub gtests
  • 09370c3: 8273487: Zero: Handle "zero" variant in runtime tests
  • 328358a: 8274349: ForkJoinPool.commonPool() does not work with 1 CPU
  • 5e90da9: 8274083: Update testing docs to mention tiered testing
  • 973911e: 8273314: Add tier4 test groups

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Oct 5, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Oct 5, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 5, 2021

@shipilev Pushed as commit f886e85.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shipilev shipilev deleted the JDK-8272703 branch Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated
2 participants