8273486: Zero: Handle DiagnoseSyncOnValueBasedClasses VM option #154
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unclean backport to fix Zero. The uncleanliness comes from the existing test shape in 17u, which uses
UseOptoBiasInlining
that is C2-specific flag, which Zero has no access to. In JDK 18, this was removed along with biased locking deprecation. I opted to fix the test in-place.Additional testing:
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u pull/154/head:pull/154
$ git checkout pull/154
Update a local copy of the PR:
$ git checkout pull/154
$ git pull https://git.openjdk.java.net/jdk17u pull/154/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 154
View PR using the GUI difftool:
$ git pr show -t 154
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u/pull/154.diff