Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8273486: Zero: Handle DiagnoseSyncOnValueBasedClasses VM option #154

Closed
wants to merge 2 commits into from
Closed

8273486: Zero: Handle DiagnoseSyncOnValueBasedClasses VM option #154

wants to merge 2 commits into from

Conversation

@shipilev
Copy link
Contributor

@shipilev shipilev commented Oct 6, 2021

Unclean backport to fix Zero. The uncleanliness comes from the existing test shape in 17u, which uses UseOptoBiasInlining that is C2-specific flag, which Zero has no access to. In JDK 18, this was removed along with biased locking deprecation. I opted to fix the test in-place.

Additional testing:

  • Linux x86_64 Zero passes the test now
  • Linux x86_64 Server continues to pass the test

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8273486: Zero: Handle DiagnoseSyncOnValueBasedClasses VM option

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u pull/154/head:pull/154
$ git checkout pull/154

Update a local copy of the PR:
$ git checkout pull/154
$ git pull https://git.openjdk.java.net/jdk17u pull/154/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 154

View PR using the GUI difftool:
$ git pr show -t 154

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u/pull/154.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 6, 2021

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot changed the title Backport 86a8e5524ddb5e25dab54b4f56cc1b9c27d0a4a6 8273486: Zero: Handle DiagnoseSyncOnValueBasedClasses VM option Oct 6, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 6, 2021

This backport pull request has now been updated with issue from the original commit.

Loading

@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 6, 2021

Webrevs

Loading

@shipilev
Copy link
Contributor Author

@shipilev shipilev commented Oct 20, 2021

Closed in favor of #209. This fixes the PR after re-creation of 17u.

Loading

@shipilev shipilev closed this Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant