8268885: duplicate checkcast when destination type is not first type of intersection type

[kvergizova]

I'd like to backport JDK-8268885 to 17u. It fixes duplicate checkcasts in javac.
The patch applies cleanly.
Tested with langtools tests, updated test fails without the fix, passes with it.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8268885: duplicate checkcast when destination type is not first type of intersection type

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u pull/158/head:pull/158
$ git checkout pull/158

Update a local copy of the PR:
$ git checkout pull/158
$ git pull https://git.openjdk.java.net/jdk17u pull/158/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 158

View PR using the GUI difftool:
$ git pr show -t 158

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u/pull/158.diff

[bridgekeeper]

👋 Welcome back evergizova! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

@kvergizova This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8268885: duplicate checkcast when destination type is not first type of intersection type

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 7 new commits pushed to the master branch:

• 9ef6d5b: 8273229: Update OS detection code to recognize Windows Server 2022
• 2243fd6: 8273695: Safepoint deadlock on VMOperation_lock
• 9b3b88e: 8272856: DoubleFlagWithIntegerValue uses G1GC-only flag
• e1847fc: 8273489: Zero: Handle UseHeavyMonitors on all monitorenter paths
• 9352fa2: 8273958: gtest/MetaspaceGtests executes unnecessary tests in debug builds
• a73ddce: 8273342: Null pointer dereference in classFileParser.cpp:2817
• 393547b: 8272846: Move some runtime/Metaspace/elastic/ tests out of tier1

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[mlbridge]

Webrevs

• 00: Full (49fa02b8)

[kvergizova]

/integrate

[openjdk]

@kvergizova
Your change (at version 49fa02b) is now ready to be sponsored by a Committer.

[yan-too]

/sponsor

[openjdk]

Going to push as commit d13334d.
Since your change was applied there have been 8 commits pushed to the master branch:

• ccb2034: 8262095: NPE in Flow$FlowAnalyzer.visitApply: Cannot invoke getThrownTypes because tree.meth.type is null
• 9ef6d5b: 8273229: Update OS detection code to recognize Windows Server 2022
• 2243fd6: 8273695: Safepoint deadlock on VMOperation_lock
• 9b3b88e: 8272856: DoubleFlagWithIntegerValue uses G1GC-only flag
• e1847fc: 8273489: Zero: Handle UseHeavyMonitors on all monitorenter paths
• 9352fa2: 8273958: gtest/MetaspaceGtests executes unnecessary tests in debug builds
• a73ddce: 8273342: Null pointer dereference in classFileParser.cpp:2817
• 393547b: 8272846: Move some runtime/Metaspace/elastic/ tests out of tier1

Your commit was automatically rebased without conflicts.

[openjdk]

@yan-too @kvergizova Pushed as commit d13334d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.