Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8273229: Update OS detection code to recognize Windows Server 2022 #160

Closed
wants to merge 1 commit into from
Closed

8273229: Update OS detection code to recognize Windows Server 2022 #160

wants to merge 1 commit into from

Conversation

RealCLanger
Copy link
Contributor

@RealCLanger RealCLanger commented Oct 7, 2021

Hi all,

this pull request contains a backport of JDK-8273229 from the openjdk/jdk repository.

The commit being backported was authored by Matthias Baesken on 2 Sep 2021 and was reviewed by Alan Bateman and David Holmes.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8273229: Update OS detection code to recognize Windows Server 2022

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u pull/160/head:pull/160
$ git checkout pull/160

Update a local copy of the PR:
$ git checkout pull/160
$ git pull https://git.openjdk.java.net/jdk17u pull/160/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 160

View PR using the GUI difftool:
$ git pr show -t 160

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u/pull/160.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 7, 2021

👋 Welcome back clanger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport c2e015c3c1a2274112bb8e6671a85bc7fb624fde 8273229: Update OS detection code to recognize Windows Server 2022 Oct 7, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 7, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

@openjdk openjdk bot commented Oct 7, 2021

@RealCLanger This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8273229: Update OS detection code to recognize Windows Server 2022

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready rfr labels Oct 7, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 7, 2021

Webrevs

@RealCLanger
Copy link
Contributor Author

@RealCLanger RealCLanger commented Oct 7, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Oct 7, 2021

Going to push as commit 9ef6d5b.
Since your change was applied there have been 3 commits pushed to the master branch:

  • 2243fd6: 8273695: Safepoint deadlock on VMOperation_lock
  • 9b3b88e: 8272856: DoubleFlagWithIntegerValue uses G1GC-only flag
  • e1847fc: 8273489: Zero: Handle UseHeavyMonitors on all monitorenter paths

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Oct 7, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Oct 7, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 7, 2021

@RealCLanger Pushed as commit 9ef6d5b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated
1 participant