Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4819544: SwingSet2 JTable Demo throws NullPointerException #163

Closed
wants to merge 1 commit into from
Closed

4819544: SwingSet2 JTable Demo throws NullPointerException #163

wants to merge 1 commit into from

Conversation

akashche
Copy link
Contributor

@akashche akashche commented Oct 7, 2021

Clean backport of a SwingSet2 demo fix. Change it to demo code only.

Additional testing:

  • checked manually with SwingSet2 that NPE does not happen

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-4819544: SwingSet2 JTable Demo throws NullPointerException

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u pull/163/head:pull/163
$ git checkout pull/163

Update a local copy of the PR:
$ git checkout pull/163
$ git pull https://git.openjdk.java.net/jdk17u pull/163/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 163

View PR using the GUI difftool:
$ git pr show -t 163

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u/pull/163.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 7, 2021

👋 Welcome back akasko! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 64d18d45ef885d5cdd893b7f56236d3f22b4b84c 4819544: SwingSet2 JTable Demo throws NullPointerException Oct 7, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 7, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

@openjdk openjdk bot commented Oct 7, 2021

@akashche This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

4819544: SwingSet2 JTable Demo throws NullPointerException

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 9ef6d5b: 8273229: Update OS detection code to recognize Windows Server 2022
  • 2243fd6: 8273695: Safepoint deadlock on VMOperation_lock

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready rfr labels Oct 7, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 7, 2021

Webrevs

@akashche
Copy link
Contributor Author

@akashche akashche commented Nov 3, 2021

Marked the bug for approval.

@akashche
Copy link
Contributor Author

@akashche akashche commented Nov 5, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Nov 5, 2021

Going to push as commit 9a2c123.
Since your change was applied there have been 106 commits pushed to the master branch:

  • 0ab99ed: 8268457: XML Transformer outputs Unicode supplementary character incorrectly to HTML
  • a834b58: 8269269: [macos11] SystemIconTest fails with ClassCastException
  • 23326d5: 8266510: Nimbus JTree default tree cell renderer does not use selected text color
  • 00fed20: 8269637: javax/swing/JFileChooser/FileSystemView/SystemIconTest.java fails on windows
  • 9f3c840: 8268361: Fix the infinite loop in next_line
  • 4003db8: 8268464: Remove dependancy of TestHttpsServer, HttpTransaction, HttpCallback from open/test/jdk/sun/net/www/protocol/https/ tests
  • 229cb35: 8269216: Useless initialization in com/sun/crypto/provider/PBES2Parameters.java
  • de47488: 8270290: NTLM authentication fails if HEAD request is used
  • 802844a: 8276066: Reset LoopPercentProfileLimit for x86 due to suboptimal performance
  • a0899bf: 8274848: LambdaMetaFactory::metafactory on REF_invokeSpecial impl method has incorrect behavior
  • ... and 96 more: https://git.openjdk.java.net/jdk17u/compare/9b3b88e2081e2547a528322d1290f6bcd52a49dd...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Nov 5, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Nov 5, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Nov 5, 2021

@akashche Pushed as commit 9a2c123.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated
1 participant