Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8271142: package help is not displayed for missing X11/extensions/Xrandr.h #167

Closed
wants to merge 1 commit into from
Closed

8271142: package help is not displayed for missing X11/extensions/Xrandr.h #167

wants to merge 1 commit into from

Conversation

MBaesken
Copy link
Member

@MBaesken MBaesken commented Oct 8, 2021

Hi all,

this pull request contains a backport of commit b7f75c0a735f0cf40ae2288d1d0ae96a571a4155 from the openjdk/jdk repository.

The commit being backported was authored by Matthias Baesken on 23 Aug 2021 and was reviewed by Christoph Langer.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8271142: package help is not displayed for missing X11/extensions/Xrandr.h

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u pull/167/head:pull/167
$ git checkout pull/167

Update a local copy of the PR:
$ git checkout pull/167
$ git pull https://git.openjdk.java.net/jdk17u pull/167/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 167

View PR using the GUI difftool:
$ git pr show -t 167

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u/pull/167.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 8, 2021

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport b7f75c0a735f0cf40ae2288d1d0ae96a571a4155 8271142: package help is not displayed for missing X11/extensions/Xrandr.h Oct 8, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 8, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

@openjdk openjdk bot commented Oct 8, 2021

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8271142: package help is not displayed for missing X11/extensions/Xrandr.h

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready rfr labels Oct 8, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 8, 2021

Webrevs

@MBaesken
Copy link
Member Author

@MBaesken MBaesken commented Oct 11, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Oct 11, 2021

Going to push as commit 9792699.
Since your change was applied there have been 2 commits pushed to the master branch:

  • 8571ae4: 8274329: Fix non-portable HotSpot code in MethodMatcher::parse_method_pattern
  • 4ce49e6: 8274325: C4819 warning at vm_version_x86.cpp on Windows after JDK-8234160

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Oct 11, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Oct 11, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 11, 2021

@MBaesken Pushed as commit 9792699.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated
1 participant