Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8274329: Fix non-portable HotSpot code in MethodMatcher::parse_method_pattern #169

Closed
wants to merge 1 commit into from
Closed

8274329: Fix non-portable HotSpot code in MethodMatcher::parse_method_pattern #169

wants to merge 1 commit into from

Conversation

DamonFool
Copy link
Member

@DamonFool DamonFool commented Oct 9, 2021


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8274329: Fix non-portable HotSpot code in MethodMatcher::parse_method_pattern

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u pull/169/head:pull/169
$ git checkout pull/169

Update a local copy of the PR:
$ git checkout pull/169
$ git pull https://git.openjdk.java.net/jdk17u pull/169/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 169

View PR using the GUI difftool:
$ git pr show -t 169

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u/pull/169.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 9, 2021

👋 Welcome back jiefu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport c833b4d130fabfa6a6f3a38313f76eb7e392c6a5 8274329: Fix non-portable HotSpot code in MethodMatcher::parse_method_pattern Oct 9, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 9, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

@openjdk openjdk bot commented Oct 9, 2021

@DamonFool This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8274329: Fix non-portable HotSpot code in MethodMatcher::parse_method_pattern

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 4ce49e6: 8274325: C4819 warning at vm_version_x86.cpp on Windows after JDK-8234160

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 9, 2021
@DamonFool
Copy link
Member Author

@DamonFool DamonFool commented Oct 9, 2021

jdk17u-fix-request had been approved.
So integrate it.
/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Oct 9, 2021

Going to push as commit 8571ae4.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 4ce49e6: 8274325: C4819 warning at vm_version_x86.cpp on Windows after JDK-8234160

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Oct 9, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 9, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 9, 2021

@DamonFool Pushed as commit 8571ae4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 9, 2021

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant