Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8273790: Potential cyclic dependencies between Gregorian and CalendarSystem #170

Closed
wants to merge 1 commit into from
Closed

8273790: Potential cyclic dependencies between Gregorian and CalendarSystem #170

wants to merge 1 commit into from

Conversation

kelthuzadx
Copy link
Member

@kelthuzadx kelthuzadx commented Oct 11, 2021


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8273790: Potential cyclic dependencies between Gregorian and CalendarSystem

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u pull/170/head:pull/170
$ git checkout pull/170

Update a local copy of the PR:
$ git checkout pull/170
$ git pull https://git.openjdk.java.net/jdk17u pull/170/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 170

View PR using the GUI difftool:
$ git pr show -t 170

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u/pull/170.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 11, 2021

👋 Welcome back yyang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport ddc262746aea99050b9a6484f51c7ddb8f4bc991 8273790: Potential cyclic dependencies between Gregorian and CalendarSystem Oct 11, 2021
@openjdk
Copy link

openjdk bot commented Oct 11, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Oct 11, 2021

@kelthuzadx This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8273790: Potential cyclic dependencies between Gregorian and CalendarSystem

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 11, 2021
@mlbridge
Copy link

mlbridge bot commented Oct 11, 2021

Webrevs

@kelthuzadx
Copy link
Member Author

kelthuzadx commented Oct 11, 2021

/integrate

@openjdk
Copy link

openjdk bot commented Oct 11, 2021

Going to push as commit f3cc4aa.
Since your change was applied there have been 2 commits pushed to the master branch:

  • 548d495: 8274074: SIGFPE with C2 compiled code with -XX:+StressGCM
  • 9792699: 8271142: package help is not displayed for missing X11/extensions/Xrandr.h

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Oct 11, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 11, 2021
@openjdk
Copy link

openjdk bot commented Oct 11, 2021

@kelthuzadx Pushed as commit f3cc4aa.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant