Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8137101: [TEST_BUG] javax/swing/plaf/basic/BasicHTML/4251579/bug4251579.java failure due to timing #172

Closed
wants to merge 1 commit into from
Closed

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Oct 11, 2021

This was backported to 11, so I think we should also have it in 17.
I had to resolve the ProblemList. The test fix applied clean.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8137101: [TEST_BUG] javax/swing/plaf/basic/BasicHTML/4251579/bug4251579.java failure due to timing

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u pull/172/head:pull/172
$ git checkout pull/172

Update a local copy of the PR:
$ git checkout pull/172
$ git pull https://git.openjdk.java.net/jdk17u pull/172/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 172

View PR using the GUI difftool:
$ git pr show -t 172

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u/pull/172.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 11, 2021

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport dcdb1b6aaad912669614ff52ad2b0b8804f204d1 8137101: [TEST_BUG] javax/swing/plaf/basic/BasicHTML/4251579/bug4251579.java failure due to timing Oct 11, 2021
@openjdk
Copy link

openjdk bot commented Oct 11, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Oct 11, 2021
@mlbridge
Copy link

mlbridge bot commented Oct 11, 2021

Webrevs

@openjdk
Copy link

openjdk bot commented Oct 11, 2021

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8137101: [TEST_BUG] javax/swing/plaf/basic/BasicHTML/4251579/bug4251579.java failure due to timing

Reviewed-by: mdoerr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • f3cc4aa: 8273790: Potential cyclic dependencies between Gregorian and CalendarSystem
  • 548d495: 8274074: SIGFPE with C2 compiled code with -XX:+StressGCM
  • 9792699: 8271142: package help is not displayed for missing X11/extensions/Xrandr.h

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 11, 2021
@GoeLin
Copy link
Member Author

GoeLin commented Oct 13, 2021

/integrate

@openjdk
Copy link

openjdk bot commented Oct 13, 2021

Going to push as commit cbd82db.
Since your change was applied there have been 12 commits pushed to the master branch:

  • 54a86bb: 8274293: Build failure on macOS with Xcode 13.0 as vfork is deprecated
  • 59ecf3c: 8270517: Add Zero support for LoongArch
  • e6f9d19: 8273176: handle latest VS2019 in abstract_vm_version
  • 1a159ca: 8274145: C2: condition incorrectly made redundant with dominating main loop exit condition
  • 1cc972f: 8271459: C2: Missing NegativeArraySizeException when creating StringBuilder with negative capacity
  • e09f6c9: 8272562: C2: assert(false) failed: Bad graph detected in build_loop_late
  • df332ff: 8267256: Extend minimal retry for loopback connections on Windows to PlainSocketImpl
  • c5a871c: 8275008: gtest build failure due to stringop-overflow warning with gcc11
  • 500ed35: 8274406: RunThese30M.java failed "assert(!LCA_orig->dominates(pred_block) || early->dominates(pred_block)) failed: early is high enough"
  • f3cc4aa: 8273790: Potential cyclic dependencies between Gregorian and CalendarSystem
  • ... and 2 more: https://git.openjdk.java.net/jdk17u/compare/8571ae43a17e4948465ece8986dca5e478938a54...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Oct 13, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 13, 2021
@openjdk
Copy link

openjdk bot commented Oct 13, 2021

@GoeLin Pushed as commit cbd82db.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the GoeLin-backport-dcdb1b6a branch October 13, 2021 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
2 participants