Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8273575: memory leak in appendBootClassPath(), paths must be deallocated #174

Closed
wants to merge 1 commit into from

Conversation

omikhaltsova
Copy link

@omikhaltsova omikhaltsova commented Oct 11, 2021

I'd like to backport JDK-8273575 to jdk17u.
The original patch applied cleanly.
The patch fixes a memory leak that should be fixed.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8273575: memory leak in appendBootClassPath(), paths must be deallocated

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u pull/174/head:pull/174
$ git checkout pull/174

Update a local copy of the PR:
$ git checkout pull/174
$ git pull https://git.openjdk.java.net/jdk17u pull/174/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 174

View PR using the GUI difftool:
$ git pr show -t 174

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u/pull/174.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 11, 2021

👋 Welcome back omikhaltcova! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 74ffe12267cb3ae63072a06f50083fd0352d8049 8273575: memory leak in appendBootClassPath(), paths must be deallocated Oct 11, 2021
@openjdk
Copy link

openjdk bot commented Oct 11, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Oct 11, 2021

@omikhaltsova This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8273575: memory leak in appendBootClassPath(), paths must be deallocated

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • 500ed35: 8274406: RunThese30M.java failed "assert(!LCA_orig->dominates(pred_block) || early->dominates(pred_block)) failed: early is high enough"
  • f3cc4aa: 8273790: Potential cyclic dependencies between Gregorian and CalendarSystem
  • 548d495: 8274074: SIGFPE with C2 compiled code with -XX:+StressGCM

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 11, 2021
@mlbridge
Copy link

mlbridge bot commented Oct 11, 2021

Webrevs

@omikhaltsova
Copy link
Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Oct 11, 2021
@openjdk
Copy link

openjdk bot commented Oct 11, 2021

@omikhaltsova
Your change (at version 815134a) is now ready to be sponsored by a Committer.

@RealCLanger
Copy link
Contributor

/sponsor

@openjdk
Copy link

openjdk bot commented Oct 28, 2021

Going to push as commit 22f1513.
Since your change was applied there have been 82 commits pushed to the master branch:

  • 38bfd62: 8273965: some testlibrary_tests/ir_framework tests fail when c1 disabled
  • f0fb814: 8174819: java/nio/file/WatchService/LotsOfEvents.java fails intermittently
  • 08cee6f: 8275104: IR framework does not handle client VM builds correctly
  • ccfe697: 8190753: (zipfs): Accessing a large entry (> 2^31 bytes) leads to a negative initial size for ByteArrayOutputStream
  • a1dc595: 8274779: HttpURLConnection: HttpClient and HttpsClient incorrectly check request method when set to POST
  • 80077e5: 8272305: several hotspot runtime/modules don't check exit codes
  • c7b9f9e: 8272391: Undeleted debug information
  • 15964f0: 8272335: runtime/cds/appcds/MoveJDKTest.java doesn't check exit codes
  • e85351d: 8271215: Fix data races in G1PeriodicGCTask
  • 031c033: 8275145: file.encoding system property has an incorrect value on Windows
  • ... and 72 more: https://git.openjdk.java.net/jdk17u/compare/9792699a122282f8862cfc573d0f90351f1c48c7...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Oct 28, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Oct 28, 2021
@openjdk
Copy link

openjdk bot commented Oct 28, 2021

@RealCLanger @omikhaltsova Pushed as commit 22f1513.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants