Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8273234: extended 'for' with expression of type tvar causes the compiler to crash #175

Closed
wants to merge 1 commit into from
Closed

8273234: extended 'for' with expression of type tvar causes the compiler to crash #175

wants to merge 1 commit into from

Conversation

kvergizova
Copy link
Contributor

@kvergizova kvergizova commented Oct 11, 2021

I'd like to backport this fix to 17u. It fixes regression in javac introduced in jdk17.
The patch applies cleanly.
Tested with langtools tests, new test fails without the patch, passes with it.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8273234: extended 'for' with expression of type tvar causes the compiler to crash

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u pull/175/head:pull/175
$ git checkout pull/175

Update a local copy of the PR:
$ git checkout pull/175
$ git pull https://git.openjdk.java.net/jdk17u pull/175/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 175

View PR using the GUI difftool:
$ git pr show -t 175

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u/pull/175.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 11, 2021

👋 Welcome back evergizova! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 8c379092747301de70db1ef8e441cbe09fd742e7 8273234: extended 'for' with expression of type tvar causes the compiler to crash Oct 11, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 11, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

@openjdk openjdk bot commented Oct 11, 2021

@kvergizova This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8273234: extended 'for' with expression of type tvar causes the compiler to crash

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 27 new commits pushed to the master branch:

  • 8cb9634: 8275049: [ZGC] missing null check in ZNMethod::log_register
  • 451611f: 8274401: C2: GraphKit::load_array_element bypasses Access API
  • 61a56e3: 8274770: [PPC64] resolve_jobject needs a generic implementation to support load barriers
  • b0e49bb: 8271855: [TESTBUG] Wrong weakCompareAndSet assumption in UnsafeIntrinsicsTest
  • 8b62d54: 8274550: c2i entry barriers read int as long on PPC
  • 6dbb3d0: 8274773: [TESTBUG] UnsafeIntrinsicsTest intermittently fails on weak memory model platform
  • efdf411: 8272720: Fix the implementation of loop unrolling heuristic with LoopPercentProfileLimit
  • ddb89c3: 8275131: Exceptions after a touchpad gesture on macOS
  • 01f4883: 8275051: Shenandoah: Correct ordering of requested gc cause and gc request flag
  • 9751b8f: 8273614: Shenandoah: intermittent timeout with ConcurrentGCBreakpoint tests
  • ... and 17 more: https://git.openjdk.java.net/jdk17u/compare/8571ae43a17e4948465ece8986dca5e478938a54...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready rfr labels Oct 11, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 11, 2021

Webrevs

@kvergizova
Copy link
Contributor Author

@kvergizova kvergizova commented Oct 18, 2021

/integrate

@openjdk openjdk bot added the sponsor label Oct 18, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 18, 2021

@kvergizova
Your change (at version bc64c2c) is now ready to be sponsored by a Committer.

@yan-too
Copy link

@yan-too yan-too commented Oct 18, 2021

/sponsor

@openjdk
Copy link

@openjdk openjdk bot commented Oct 18, 2021

Going to push as commit 6081dca.
Since your change was applied there have been 27 commits pushed to the master branch:

  • 8cb9634: 8275049: [ZGC] missing null check in ZNMethod::log_register
  • 451611f: 8274401: C2: GraphKit::load_array_element bypasses Access API
  • 61a56e3: 8274770: [PPC64] resolve_jobject needs a generic implementation to support load barriers
  • b0e49bb: 8271855: [TESTBUG] Wrong weakCompareAndSet assumption in UnsafeIntrinsicsTest
  • 8b62d54: 8274550: c2i entry barriers read int as long on PPC
  • 6dbb3d0: 8274773: [TESTBUG] UnsafeIntrinsicsTest intermittently fails on weak memory model platform
  • efdf411: 8272720: Fix the implementation of loop unrolling heuristic with LoopPercentProfileLimit
  • ddb89c3: 8275131: Exceptions after a touchpad gesture on macOS
  • 01f4883: 8275051: Shenandoah: Correct ordering of requested gc cause and gc request flag
  • 9751b8f: 8273614: Shenandoah: intermittent timeout with ConcurrentGCBreakpoint tests
  • ... and 17 more: https://git.openjdk.java.net/jdk17u/compare/8571ae43a17e4948465ece8986dca5e478938a54...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Oct 18, 2021
@openjdk openjdk bot added integrated and removed ready rfr sponsor labels Oct 18, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 18, 2021

@yan-too @kvergizova Pushed as commit 6081dca.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated
2 participants