Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8272562: C2: assert(false) failed: Bad graph detected in build_loop_late #176

Closed
wants to merge 1 commit into from
Closed

8272562: C2: assert(false) failed: Bad graph detected in build_loop_late #176

wants to merge 1 commit into from

Conversation

TobiHartmann
Copy link
Member

@TobiHartmann TobiHartmann commented Oct 11, 2021

Backport of JDK-8272562. Applies cleanly.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8272562: C2: assert(false) failed: Bad graph detected in build_loop_late

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u pull/176/head:pull/176
$ git checkout pull/176

Update a local copy of the PR:
$ git checkout pull/176
$ git pull https://git.openjdk.java.net/jdk17u pull/176/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 176

View PR using the GUI difftool:
$ git pr show -t 176

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u/pull/176.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 11, 2021

👋 Welcome back thartmann! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 980c50dc607e60e12879bd6fb7ff4034469e88d8 8272562: C2: assert(false) failed: Bad graph detected in build_loop_late Oct 11, 2021
@openjdk
Copy link

openjdk bot commented Oct 11, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Oct 11, 2021

@TobiHartmann This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8272562: C2: assert(false) failed: Bad graph detected in build_loop_late

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 11, 2021
@mlbridge
Copy link

mlbridge bot commented Oct 11, 2021

Webrevs

@TobiHartmann
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Oct 12, 2021

Going to push as commit e09f6c9.
Since your change was applied there have been 2 commits pushed to the master branch:

  • df332ff: 8267256: Extend minimal retry for loopback connections on Windows to PlainSocketImpl
  • c5a871c: 8275008: gtest build failure due to stringop-overflow warning with gcc11

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Oct 12, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 12, 2021
@openjdk
Copy link

openjdk bot commented Oct 12, 2021

@TobiHartmann Pushed as commit e09f6c9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants