8271459: C2: Missing NegativeArraySizeException when creating StringBuilder with negative capacity

[TobiHartmann]

Backport of JDK-8271459. Did not apply cleanly due to changes in IRNode.java. Approval is pending.

Thanks,
Tobias

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8271459: C2: Missing NegativeArraySizeException when creating StringBuilder with negative capacity

Reviewers

• Christian Hagedorn (@chhagedorn - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u pull/177/head:pull/177
$ git checkout pull/177

Update a local copy of the PR:
$ git checkout pull/177
$ git pull https://git.openjdk.java.net/jdk17u pull/177/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 177

View PR using the GUI difftool:
$ git pr show -t 177

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u/pull/177.diff

[bridgekeeper]

👋 Welcome back thartmann! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[chhagedorn]

Looks good!

[openjdk]

@TobiHartmann This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8271459: C2: Missing NegativeArraySizeException when creating StringBuilder with negative capacity

Reviewed-by: chagedorn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[mlbridge]

Webrevs

• 00: Full (79ed81f1)

[TobiHartmann]

Thanks for the review, Christian!

[TobiHartmann]

/integrate

[openjdk]

Going to push as commit 1cc972f.
Since your change was applied there have been 3 commits pushed to the master branch:

• e09f6c9: 8272562: C2: assert(false) failed: Bad graph detected in build_loop_late
• df332ff: 8267256: Extend minimal retry for loopback connections on Windows to PlainSocketImpl
• c5a871c: 8275008: gtest build failure due to stringop-overflow warning with gcc11

Your commit was automatically rebased without conflicts.

[openjdk]

@TobiHartmann Pushed as commit 1cc972f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.