Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8274407: (tz) Update Timezone Data to 2021c #180

Closed
wants to merge 1 commit into from
Closed

8274407: (tz) Update Timezone Data to 2021c #180

wants to merge 1 commit into from

Conversation

satoyoshiki
Copy link

@satoyoshiki satoyoshiki commented Oct 12, 2021

Backport-of: 8ca084617f331b6af934179f3f776c8158da5bba


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issues

  • JDK-8274407: (tz) Update Timezone Data to 2021c ⚠️ Issue is not open.
  • JDK-8274467: TestZoneInfo310.java fails with tzdata2021b ⚠️ Issue is not open.
  • JDK-8274468: TimeZoneTest.java fails with tzdata2021b ⚠️ Issue is not open.

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u pull/180/head:pull/180
$ git checkout pull/180

Update a local copy of the PR:
$ git checkout pull/180
$ git pull https://git.openjdk.java.net/jdk17u pull/180/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 180

View PR using the GUI difftool:
$ git pr show -t 180

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u/pull/180.diff

Backport-of: 8ca084617f331b6af934179f3f776c8158da5bba
@satoyoshiki
Copy link
Author

@satoyoshiki satoyoshiki commented Oct 12, 2021

/issue 8274407 8274467 8274468

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 12, 2021

👋 Welcome back ysatowse! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Clean backport of 8ca084617f331b6af934179f3f776c8158da5bba 8274407: (tz) Update Timezone Data to 2021c Oct 12, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 12, 2021

@satoyoshiki The primary solved issue for a PR is set through the PR title. Since the current title does not contain an issue reference, it will now be updated.

Adding additional issue to issue list: 8274467: TestZoneInfo310.java fails with tzdata2021b.

Adding additional issue to issue list: 8274468: TimeZoneTest.java fails with tzdata2021b.

@satoyoshiki satoyoshiki marked this pull request as ready for review Oct 13, 2021
@openjdk openjdk bot added the rfr label Oct 13, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 13, 2021

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented Oct 13, 2021

@satoyoshiki This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8274407: (tz) Update Timezone Data to 2021c
8274467: TestZoneInfo310.java fails with tzdata2021b
8274468: TimeZoneTest.java fails with tzdata2021b

Reviewed-by: coffeys

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 10 new commits pushed to the master branch:

  • 47c129d: 8269656: The test test/langtools/tools/javac/versions/Versions.java has duplicate test cycles
  • cbd82db: 8137101: [TEST_BUG] javax/swing/plaf/basic/BasicHTML/4251579/bug4251579.java failure due to timing
  • 54a86bb: 8274293: Build failure on macOS with Xcode 13.0 as vfork is deprecated
  • 59ecf3c: 8270517: Add Zero support for LoongArch
  • e6f9d19: 8273176: handle latest VS2019 in abstract_vm_version
  • 1a159ca: 8274145: C2: condition incorrectly made redundant with dominating main loop exit condition
  • 1cc972f: 8271459: C2: Missing NegativeArraySizeException when creating StringBuilder with negative capacity
  • e09f6c9: 8272562: C2: assert(false) failed: Bad graph detected in build_loop_late
  • df332ff: 8267256: Extend minimal retry for loopback connections on Windows to PlainSocketImpl
  • c5a871c: 8275008: gtest build failure due to stringop-overflow warning with gcc11

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@coffeys) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Oct 13, 2021
@satoyoshiki
Copy link
Author

@satoyoshiki satoyoshiki commented Oct 13, 2021

/integrate

@openjdk openjdk bot added the sponsor label Oct 13, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 13, 2021

@satoyoshiki
Your change (at version 19efeb5) is now ready to be sponsored by a Committer.

@coffeys
Copy link
Contributor

@coffeys coffeys commented Oct 13, 2021

/sponsor

@openjdk
Copy link

@openjdk openjdk bot commented Oct 13, 2021

Going to push as commit bbcb072.
Since your change was applied there have been 10 commits pushed to the master branch:

  • 47c129d: 8269656: The test test/langtools/tools/javac/versions/Versions.java has duplicate test cycles
  • cbd82db: 8137101: [TEST_BUG] javax/swing/plaf/basic/BasicHTML/4251579/bug4251579.java failure due to timing
  • 54a86bb: 8274293: Build failure on macOS with Xcode 13.0 as vfork is deprecated
  • 59ecf3c: 8270517: Add Zero support for LoongArch
  • e6f9d19: 8273176: handle latest VS2019 in abstract_vm_version
  • 1a159ca: 8274145: C2: condition incorrectly made redundant with dominating main loop exit condition
  • 1cc972f: 8271459: C2: Missing NegativeArraySizeException when creating StringBuilder with negative capacity
  • e09f6c9: 8272562: C2: assert(false) failed: Bad graph detected in build_loop_late
  • df332ff: 8267256: Extend minimal retry for loopback connections on Windows to PlainSocketImpl
  • c5a871c: 8275008: gtest build failure due to stringop-overflow warning with gcc11

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Oct 13, 2021
@openjdk openjdk bot added integrated and removed ready rfr sponsor labels Oct 13, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 13, 2021

@coffeys @satoyoshiki Pushed as commit bbcb072.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated
2 participants