Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8274293: Build failure on macOS with Xcode 13.0 as vfork is deprecated #183

Closed
wants to merge 1 commit into from
Closed

8274293: Build failure on macOS with Xcode 13.0 as vfork is deprecated #183

wants to merge 1 commit into from

Conversation

xpbob
Copy link

@xpbob xpbob commented Oct 12, 2021

Backport 252aaa9249d8979366b37d59487b5b039d923e35


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8274293: Build failure on macOS with Xcode 13.0 as vfork is deprecated

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u pull/183/head:pull/183
$ git checkout pull/183

Update a local copy of the PR:
$ git checkout pull/183
$ git pull https://git.openjdk.java.net/jdk17u pull/183/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 183

View PR using the GUI difftool:
$ git pr show -t 183

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u/pull/183.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 12, 2021

👋 Welcome back xpbob! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 252aaa9249d8979366b37d59487b5b039d923e35 8274293: Build failure on macOS with Xcode 13.0 as vfork is deprecated Oct 12, 2021
@openjdk
Copy link

openjdk bot commented Oct 12, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Oct 12, 2021

@xpbob This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8274293: Build failure on macOS with Xcode 13.0 as vfork is deprecated

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

  • 59ecf3c: 8270517: Add Zero support for LoongArch
  • e6f9d19: 8273176: handle latest VS2019 in abstract_vm_version
  • 1a159ca: 8274145: C2: condition incorrectly made redundant with dominating main loop exit condition
  • 1cc972f: 8271459: C2: Missing NegativeArraySizeException when creating StringBuilder with negative capacity
  • e09f6c9: 8272562: C2: assert(false) failed: Bad graph detected in build_loop_late
  • df332ff: 8267256: Extend minimal retry for loopback connections on Windows to PlainSocketImpl

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 12, 2021
@xpbob
Copy link
Author

xpbob commented Oct 12, 2021

/test

@mlbridge
Copy link

mlbridge bot commented Oct 12, 2021

Webrevs

@xpbob
Copy link
Author

xpbob commented Oct 12, 2021

I open the test action before pull request. but test not run.

@DamonFool
Copy link
Member

I open the test action before pull request. but test not run.

I've no idea why it didn't test for your PR.

I think it's OK to go since it's a clean backport.
However, it would be better if you can test tier1 on Mac before integration.
Thanks.

@xpbob
Copy link
Author

xpbob commented Oct 12, 2021

tier1 testing finished, no regression

@xpbob
Copy link
Author

xpbob commented Oct 12, 2021

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Oct 12, 2021
@openjdk
Copy link

openjdk bot commented Oct 12, 2021

@xpbob
Your change (at version 7ed0357) is now ready to be sponsored by a Committer.

@DamonFool
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Oct 12, 2021

Going to push as commit 54a86bb.
Since your change was applied there have been 6 commits pushed to the master branch:

  • 59ecf3c: 8270517: Add Zero support for LoongArch
  • e6f9d19: 8273176: handle latest VS2019 in abstract_vm_version
  • 1a159ca: 8274145: C2: condition incorrectly made redundant with dominating main loop exit condition
  • 1cc972f: 8271459: C2: Missing NegativeArraySizeException when creating StringBuilder with negative capacity
  • e09f6c9: 8272562: C2: assert(false) failed: Bad graph detected in build_loop_late
  • df332ff: 8267256: Extend minimal retry for loopback connections on Windows to PlainSocketImpl

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Oct 12, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Oct 12, 2021
@openjdk
Copy link

openjdk bot commented Oct 12, 2021

@DamonFool @xpbob Pushed as commit 54a86bb.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants