Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8273176: handle latest VS2019 in abstract_vm_version #185

Closed
wants to merge 1 commit into from
Closed

8273176: handle latest VS2019 in abstract_vm_version #185

wants to merge 1 commit into from

Conversation

MBaesken
Copy link
Member

@MBaesken MBaesken commented Oct 12, 2021


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8273176: handle latest VS2019 in abstract_vm_version

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u pull/185/head:pull/185
$ git checkout pull/185

Update a local copy of the PR:
$ git checkout pull/185
$ git pull https://git.openjdk.java.net/jdk17u pull/185/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 185

View PR using the GUI difftool:
$ git pr show -t 185

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u/pull/185.diff

@MBaesken
Copy link
Member Author

/integrate

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 12, 2021

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 0e14bf70cf6e482a2ec7d13ed37df0bee911740d 8273176: handle latest VS2019 in abstract_vm_version Oct 12, 2021
@openjdk
Copy link

openjdk bot commented Oct 12, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Oct 12, 2021

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8273176: handle latest VS2019 in abstract_vm_version

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 8 new commits pushed to the master branch:

  • 1a159ca: 8274145: C2: condition incorrectly made redundant with dominating main loop exit condition
  • 1cc972f: 8271459: C2: Missing NegativeArraySizeException when creating StringBuilder with negative capacity
  • e09f6c9: 8272562: C2: assert(false) failed: Bad graph detected in build_loop_late
  • df332ff: 8267256: Extend minimal retry for loopback connections on Windows to PlainSocketImpl
  • c5a871c: 8275008: gtest build failure due to stringop-overflow warning with gcc11
  • 500ed35: 8274406: RunThese30M.java failed "assert(!LCA_orig->dominates(pred_block) || early->dominates(pred_block)) failed: early is high enough"
  • f3cc4aa: 8273790: Potential cyclic dependencies between Gregorian and CalendarSystem
  • 548d495: 8274074: SIGFPE with C2 compiled code with -XX:+StressGCM

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 12, 2021
@openjdk
Copy link

openjdk bot commented Oct 12, 2021

Going to push as commit e6f9d19.
Since your change was applied there have been 8 commits pushed to the master branch:

  • 1a159ca: 8274145: C2: condition incorrectly made redundant with dominating main loop exit condition
  • 1cc972f: 8271459: C2: Missing NegativeArraySizeException when creating StringBuilder with negative capacity
  • e09f6c9: 8272562: C2: assert(false) failed: Bad graph detected in build_loop_late
  • df332ff: 8267256: Extend minimal retry for loopback connections on Windows to PlainSocketImpl
  • c5a871c: 8275008: gtest build failure due to stringop-overflow warning with gcc11
  • 500ed35: 8274406: RunThese30M.java failed "assert(!LCA_orig->dominates(pred_block) || early->dominates(pred_block)) failed: early is high enough"
  • f3cc4aa: 8273790: Potential cyclic dependencies between Gregorian and CalendarSystem
  • 548d495: 8274074: SIGFPE with C2 compiled code with -XX:+StressGCM

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Oct 12, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 12, 2021
@openjdk
Copy link

openjdk bot commented Oct 12, 2021

@MBaesken Pushed as commit e6f9d19.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mlbridge
Copy link

mlbridge bot commented Oct 12, 2021

Webrevs

@MBaesken
Copy link
Member Author

/backport jdk11u-dev

@openjdk
Copy link

openjdk bot commented Mar 28, 2022

@MBaesken Unknown command backport - for a list of valid commands use /help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant