8273505: runtime/cds/appcds/loaderConstraints/DynamicLoaderConstraintsTest.java#default-cl crashed with SIGSEGV in MetaspaceShared::link_shared_classes

[hseigel]

Please review this JDK-17u backport of the fix for JDK-8273505. The patch applied cleanly except that MetaspaceShared::link_shared_classes() is called MetaspaceShared::link_and_cleanup_shared_classes() in JDK-17u. The backport was tested with Mach5 tiers 1-2 on Linux, Mac OS, and Windows, and Mach5 tiers 3-5 on Linux x64.

Thanks, Harold

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8273505: runtime/cds/appcds/loaderConstraints/DynamicLoaderConstraintsTest.java#default-cl crashed with SIGSEGV in MetaspaceShared::link_shared_classes

Reviewers

• Calvin Cheung (@calvinccheung - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u pull/187/head:pull/187
$ git checkout pull/187

Update a local copy of the PR:
$ git checkout pull/187
$ git pull https://git.openjdk.java.net/jdk17u pull/187/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 187

View PR using the GUI difftool:
$ git pr show -t 187

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u/pull/187.diff

[bridgekeeper]

👋 Welcome back hseigel! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

@hseigel This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8273505: runtime/cds/appcds/loaderConstraints/DynamicLoaderConstraintsTest.java#default-cl crashed with SIGSEGV in MetaspaceShared::link_shared_classes

Reviewed-by: ccheung

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

• bbcb072: 8274407: (tz) Update Timezone Data to 2021c
• 47c129d: 8269656: The test test/langtools/tools/javac/versions/Versions.java has duplicate test cycles
• cbd82db: 8137101: [TEST_BUG] javax/swing/plaf/basic/BasicHTML/4251579/bug4251579.java failure due to timing

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[mlbridge]

Webrevs

• 00: Full (e4c389b4)

[calvinccheung]

LGTM

[hseigel]

Thanks Calvin!

/integrate

[openjdk]

Going to push as commit aabc4ba.
Since your change was applied there have been 4 commits pushed to the master branch:

• e79cb9c: 8274840: Update OS detection code to recognize Windows 11
• bbcb072: 8274407: (tz) Update Timezone Data to 2021c
• 47c129d: 8269656: The test test/langtools/tools/javac/versions/Versions.java has duplicate test cycles
• cbd82db: 8137101: [TEST_BUG] javax/swing/plaf/basic/BasicHTML/4251579/bug4251579.java failure due to timing

Your commit was automatically rebased without conflicts.

[openjdk]

@hseigel Pushed as commit aabc4ba.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.