Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8271276: C2: Wrong JVM state used for receiver null check #19

Closed
wants to merge 1 commit into from
Closed

8271276: C2: Wrong JVM state used for receiver null check #19

wants to merge 1 commit into from

Conversation

@TobiHartmann
Copy link
Member

@TobiHartmann TobiHartmann commented Aug 18, 2021

Backport of JDK-8271276. Applies cleanly.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8271276: C2: Wrong JVM state used for receiver null check

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u pull/19/head:pull/19
$ git checkout pull/19

Update a local copy of the PR:
$ git checkout pull/19
$ git pull https://git.openjdk.java.net/jdk17u pull/19/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19

View PR using the GUI difftool:
$ git pr show -t 19

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u/pull/19.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Aug 18, 2021

👋 Welcome back thartmann! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot changed the title Backport e8f1219d6f471c89fe15b19c56e3062dd668466f 8271276: C2: Wrong JVM state used for receiver null check Aug 18, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Aug 18, 2021

This backport pull request has now been updated with issue from the original commit.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Aug 18, 2021

@TobiHartmann This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8271276: C2: Wrong JVM state used for receiver null check

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@mlbridge
Copy link

@mlbridge mlbridge bot commented Aug 18, 2021

Webrevs

Loading

@TobiHartmann
Copy link
Member Author

@TobiHartmann TobiHartmann commented Aug 18, 2021

/integrate

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Aug 18, 2021

Going to push as commit 66bd0d5.
Since your change was applied there have been 4 commits pushed to the master branch:

  • 32f026a: 8268963: [IR Framework] Some default regexes matching on PrintOptoAssembly in IRNode.java do not work on all platforms
  • 9489ab7: 8271925: ZGC: Arraycopy stub passes invalid oop to load barrier
  • 90341db: 8268019: C2: assert(no_dead_loop) failed: dead loop detected
  • 52c3e7d: 8270098: ZGC: ZBarrierSetC2::clone_at_expansion fails with "Guard against surprises" assert

Your commit was automatically rebased without conflicts.

Loading

@openjdk openjdk bot closed this Aug 18, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Aug 18, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Aug 18, 2021

@TobiHartmann Pushed as commit 66bd0d5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant