Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8274795: AArch64: avoid spilling and restoring r18 in macro assembler #197

Closed
wants to merge 1 commit into from
Closed

8274795: AArch64: avoid spilling and restoring r18 in macro assembler #197

wants to merge 1 commit into from

Conversation

lewurm
Copy link
Member

@lewurm lewurm commented Oct 15, 2021

Clean backport of JDK-8274795 / openjdk/jdk@ede3f4e


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8274795: AArch64: avoid spilling and restoring r18 in macro assembler

Reviewers

  • vkempik - Committer ⚠️ Added manually

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u pull/197/head:pull/197
$ git checkout pull/197

Update a local copy of the PR:
$ git checkout pull/197
$ git pull https://git.openjdk.java.net/jdk17u pull/197/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 197

View PR using the GUI difftool:
$ git pr show -t 197

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u/pull/197.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 15, 2021

👋 Welcome back burban! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Oct 15, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 15, 2021

Webrevs

@VladimirKempik
Copy link

@VladimirKempik VladimirKempik commented Oct 15, 2021

lets wait a week before pushing this to jdk17u
might get some feedback from oracle/others if the original patch doesn't pass some testing.

@VladimirKempik
Copy link

@VladimirKempik VladimirKempik commented Oct 15, 2021

Btw, rename the pull request to "Backport ede3f4e94c752a8457b7c24e001bd122845d2f6a"
this will get you backport label and the ready label too ( if it's really a clean backport)

@lewurm lewurm changed the title JDK-8274795: AArch64: avoid spilling and restoring r18 in macro assembler Backport ede3f4e94c752a8457b7c24e001bd122845d2f6a Oct 20, 2021
@openjdk openjdk bot changed the title Backport ede3f4e94c752a8457b7c24e001bd122845d2f6a 8274795: AArch64: avoid spilling and restoring r18 in macro assembler Oct 20, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 20, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

@openjdk openjdk bot commented Oct 20, 2021

@lewurm This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8274795: AArch64: avoid spilling and restoring r18 in macro assembler

Reviewed-by: vkempik
Backport-of: ede3f4e94c752a8457b7c24e001bd122845d2f6a

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 68 new commits pushed to the master branch:

  • 25bfea6: 8276130: Fix Github Actions of JDK17u to account for update version scheme
  • 22f1513: 8273575: memory leak in appendBootClassPath(), paths must be deallocated
  • 38bfd62: 8273965: some testlibrary_tests/ir_framework tests fail when c1 disabled
  • f0fb814: 8174819: java/nio/file/WatchService/LotsOfEvents.java fails intermittently
  • 08cee6f: 8275104: IR framework does not handle client VM builds correctly
  • ccfe697: 8190753: (zipfs): Accessing a large entry (> 2^31 bytes) leads to a negative initial size for ByteArrayOutputStream
  • a1dc595: 8274779: HttpURLConnection: HttpClient and HttpsClient incorrectly check request method when set to POST
  • 80077e5: 8272305: several hotspot runtime/modules don't check exit codes
  • c7b9f9e: 8272391: Undeleted debug information
  • 15964f0: 8272335: runtime/cds/appcds/MoveJDKTest.java doesn't check exit codes
  • ... and 58 more: https://git.openjdk.java.net/jdk17u/compare/aabc4ba0eef9e47fc547b4ec91153a9427acd968...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Oct 20, 2021
@lewurm
Copy link
Member Author

@lewurm lewurm commented Oct 28, 2021

@VladimirKempik do you think it would be good to go now?

@VladimirKempik
Copy link

@VladimirKempik VladimirKempik commented Oct 28, 2021

Hello, i'm not a formal reviewer in jdk-updates project. LGTM, you can just "reviewer credit" me.

@lewurm
Copy link
Member Author

@lewurm lewurm commented Oct 29, 2021

/reviewer credit @VladimirKempik

@openjdk
Copy link

@openjdk openjdk bot commented Oct 29, 2021

@lewurm
Reviewer vkempik successfully credited.

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Nov 26, 2021

@lewurm This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@lewurm
Copy link
Member Author

@lewurm lewurm commented Dec 3, 2021

@VladimirKempik @theRealAph is this fine to backport?

@kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Dec 3, 2021

@robm-openjdk is still the maintainer for this code line, so that's a question for him.

@VladimirKempik
Copy link

@VladimirKempik VladimirKempik commented Dec 3, 2021

this might be a little too late for jdk17.0.2 now, but since 17 is LTS, it's still needs to get pushed. Just place jdk17u-fix-request label on the bug ( with proper request comment) and lets see what @robm-openjdk will answer.
Could you also create a backport to jdk11u please.

@robm-openjdk
Copy link
Member

@robm-openjdk robm-openjdk commented Dec 3, 2021

I'm afraid the cutoff date for 17.0.2 has passed. A call for votes for new maintainers will commence next week. They will approve any future OpenJDK 17u issues.

@lewurm
Copy link
Member Author

@lewurm lewurm commented Dec 21, 2021

is it fine to land now?

@VladimirKempik
Copy link

@VladimirKempik VladimirKempik commented Dec 22, 2021

you need to rebase on jdk17u-dev, the jdk17u is not accepting PRs anymore

@lewurm
Copy link
Member Author

@lewurm lewurm commented Dec 22, 2021

ok, I've opened this one instead: openjdk/jdk17u-dev#28

@lewurm lewurm closed this Dec 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean ready rfr
4 participants