Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8275051: Shenandoah: Correct ordering of requested gc cause and gc request flag #198

Closed
wants to merge 1 commit into from
Closed

Conversation

zhengyu123
Copy link
Contributor

@zhengyu123 zhengyu123 commented Oct 15, 2021

I would like to backport this Shenandoah specific patch to 17u.

The patch corrects order of a couple of GC flags to ensure that GC reads the latest GC cause when a GC is requested.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8275051: Shenandoah: Correct ordering of requested gc cause and gc request flag

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u pull/198/head:pull/198
$ git checkout pull/198

Update a local copy of the PR:
$ git checkout pull/198
$ git pull https://git.openjdk.java.net/jdk17u pull/198/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 198

View PR using the GUI difftool:
$ git pr show -t 198

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u/pull/198.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 15, 2021

👋 Welcome back zgu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 1ab64143c06e33e23172dd77c39e434443347364 8275051: Shenandoah: Correct ordering of requested gc cause and gc request flag Oct 15, 2021
@openjdk
Copy link

openjdk bot commented Oct 15, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Oct 15, 2021

@zhengyu123 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8275051: Shenandoah: Correct ordering of requested gc cause and gc request flag

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 15, 2021
@mlbridge
Copy link

mlbridge bot commented Oct 15, 2021

Webrevs

@zhengyu123
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Oct 17, 2021

Going to push as commit 01f4883.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 9751b8f: 8273614: Shenandoah: intermittent timeout with ConcurrentGCBreakpoint tests

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Oct 17, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 17, 2021
@openjdk
Copy link

openjdk bot commented Oct 17, 2021

@zhengyu123 Pushed as commit 01f4883.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant