Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8238649: Call new Win32 API SetThreadDescription in os::set_native_thread_name #204

Closed
wants to merge 1 commit into from
Closed

Conversation

akashche
Copy link
Contributor

@akashche akashche commented Oct 19, 2021

Clean backport of a Windows-specific enhancement.

Note, there is a follow-up fix: JDK-8268927 to this backport.

Additional testing (with JDK-8268927):

  • fastdebug tier1 on Windows 2016

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8238649: Call new Win32 API SetThreadDescription in os::set_native_thread_name

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u pull/204/head:pull/204
$ git checkout pull/204

Update a local copy of the PR:
$ git checkout pull/204
$ git pull https://git.openjdk.java.net/jdk17u pull/204/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 204

View PR using the GUI difftool:
$ git pr show -t 204

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u/pull/204.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 19, 2021

👋 Welcome back akasko! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 9f3c7e74ff00a7550742ed8b9d6671c2d4bb6041 8238649: Call new Win32 API SetThreadDescription in os::set_native_thread_name Oct 19, 2021
@openjdk
Copy link

openjdk bot commented Oct 19, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Oct 19, 2021

@akashche This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8238649: Call new Win32 API SetThreadDescription in os::set_native_thread_name

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 19, 2021
@mlbridge
Copy link

mlbridge bot commented Oct 19, 2021

Webrevs

@akashche
Copy link
Contributor Author

akashche commented Nov 3, 2021

Marked the bug for approval.

@akashche
Copy link
Contributor Author

akashche commented Nov 10, 2021

/integrate

@openjdk
Copy link

openjdk bot commented Nov 10, 2021

Going to push as commit 7aaad16.
Since your change was applied there have been 87 commits pushed to the master branch:

  • 16a191c: 8261579: AArch64: Support for weaker memory ordering in Atomic
  • 89a03fe: 8273450: Fix the copyright header of SVML files
  • 6bb5494: 8276572: Fake libsyslookup.so library causes tooling issues
  • 4eeefb4: 8275666: serviceability/jvmti/GetObjectSizeClass.java shouldn't have vm.flagless
  • ed48774: 8274523: java/lang/management/MemoryMXBean/MemoryTest.java test should handle Shenandoah
  • acd939e: 8274522: java/lang/management/ManagementFactory/MXBeanException.java test fails with Shenandoah
  • 0b52b9d: 8276550: Use SHA256 hash in build.tools.depend.Depend
  • 05ad02f: 8268284: javax/swing/JComponent/7154030/bug7154030.java fails with "Exception: Failed to hide opaque button"
  • 143cc64: 8273026: Slow LoginContext.login() on multi threading application
  • aadd484: 8271895: UnProblemList javax/swing/JComponent/7154030/bug7154030.java in JDK18
  • ... and 77 more: https://git.openjdk.java.net/jdk17u/compare/ee02c6426769ef15578ae2505658a401d1f13469...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Nov 10, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 10, 2021
@openjdk
Copy link

openjdk bot commented Nov 10, 2021

@akashche Pushed as commit 7aaad16.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant