Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8270946: X509CertImpl.getFingerprint should not return the empty String #206

Closed
wants to merge 1 commit into from

Conversation

@alexeybakhtin
Copy link
Contributor

@alexeybakhtin alexeybakhtin commented Oct 19, 2021

Clean backport of X509CertImpl.getFingerprint issue


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8270946: X509CertImpl.getFingerprint should not return the empty String

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u pull/206/head:pull/206
$ git checkout pull/206

Update a local copy of the PR:
$ git checkout pull/206
$ git pull https://git.openjdk.java.net/jdk17u pull/206/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 206

View PR using the GUI difftool:
$ git pr show -t 206

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u/pull/206.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 19, 2021

👋 Welcome back abakhtin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot changed the title Backport fc80a6b49364594fafa0e2efc769d2f6234cfa22 8270946: X509CertImpl.getFingerprint should not return the empty String Oct 19, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 19, 2021

This backport pull request has now been updated with issue from the original commit.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Oct 19, 2021

@alexeybakhtin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8270946: X509CertImpl.getFingerprint should not return the empty String

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 41 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

Loading

@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 19, 2021

Webrevs

Loading

@alexeybakhtin
Copy link
Contributor Author

@alexeybakhtin alexeybakhtin commented Oct 21, 2021

/integrate

Loading

@openjdk openjdk bot added the sponsor label Oct 21, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 21, 2021

@alexeybakhtin
Your change (at version 4512adf) is now ready to be sponsored by a Committer.

Loading

@yan-too
Copy link

@yan-too yan-too commented Oct 21, 2021

/sponsor

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Oct 21, 2021

Going to push as commit facbabb.
Since your change was applied there have been 41 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Oct 21, 2021

@yan-too @alexeybakhtin Pushed as commit facbabb.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants