-
Notifications
You must be signed in to change notification settings - Fork 178
8273486: Zero: Handle DiagnoseSyncOnValueBasedClasses VM option #209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back shade! A progress list of the required criteria for merging this PR into |
Any takers? :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm.
@shipilev This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 137 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
Thanks! Got the push approval too. /integrate |
Going to push as commit 1d11bcd.
Your commit was automatically rebased without conflicts. |
Unclean backport to fix Zero. The uncleanliness comes from the existing test shape in 17u, which uses
UseOptoBiasInlining
that is C2-specific flag, which Zero has no access to. In JDK 18, this was removed along with biased locking deprecation. I opted to fix the test in-place.Additional testing:
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u pull/209/head:pull/209
$ git checkout pull/209
Update a local copy of the PR:
$ git checkout pull/209
$ git pull https://git.openjdk.java.net/jdk17u pull/209/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 209
View PR using the GUI difftool:
$ git pr show -t 209
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u/pull/209.diff