Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8274501: c2i entry barriers read int as long on AArch64 #211

Closed
wants to merge 1 commit into from
Closed

8274501: c2i entry barriers read int as long on AArch64 #211

wants to merge 1 commit into from

Conversation

snazarkin
Copy link
Contributor

@snazarkin snazarkin commented Oct 22, 2021

Clean backport of one-liner with P2 prio. Tested with tier1


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8274501: c2i entry barriers read int as long on AArch64

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u pull/211/head:pull/211
$ git checkout pull/211

Update a local copy of the PR:
$ git checkout pull/211
$ git pull https://git.openjdk.java.net/jdk17u pull/211/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 211

View PR using the GUI difftool:
$ git pr show -t 211

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u/pull/211.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 22, 2021

👋 Welcome back snazarki! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@snazarkin snazarkin changed the title Backport of f08180f35f18263e33d96b6d1f06e5129328f01a Backport f08180f35f18263e33d96b6d1f06e5129328f01a Oct 22, 2021
@openjdk openjdk bot changed the title Backport f08180f35f18263e33d96b6d1f06e5129328f01a 8274501: c2i entry barriers read int as long on AArch64 Oct 22, 2021
@openjdk
Copy link

openjdk bot commented Oct 22, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Oct 22, 2021

@snazarkin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8274501: c2i entry barriers read int as long on AArch64

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 184 new commits pushed to the master branch:

  • 583844a: 8275302: unexpected compiler error: cast, intersection types and sealed
  • 0364737: 8276122: Change openjdk project in jcheck to jdk-updates
  • 25bfea6: 8276130: Fix Github Actions of JDK17u to account for update version scheme
  • 22f1513: 8273575: memory leak in appendBootClassPath(), paths must be deallocated
  • 38bfd62: 8273965: some testlibrary_tests/ir_framework tests fail when c1 disabled
  • f0fb814: 8174819: java/nio/file/WatchService/LotsOfEvents.java fails intermittently
  • 08cee6f: 8275104: IR framework does not handle client VM builds correctly
  • ccfe697: 8190753: (zipfs): Accessing a large entry (> 2^31 bytes) leads to a negative initial size for ByteArrayOutputStream
  • a1dc595: 8274779: HttpURLConnection: HttpClient and HttpsClient incorrectly check request method when set to POST
  • 80077e5: 8272305: several hotspot runtime/modules don't check exit codes
  • ... and 174 more: https://git.openjdk.java.net/jdk17u/compare/cef269f89633331a68c9549a08d2d88d5534b8fa...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 22, 2021
@mlbridge
Copy link

mlbridge bot commented Oct 22, 2021

Webrevs

@snazarkin
Copy link
Contributor Author

snazarkin commented Nov 1, 2021

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Nov 1, 2021
@openjdk
Copy link

openjdk bot commented Nov 1, 2021

@snazarkin
Your change (at version 0bf290f) is now ready to be sponsored by a Committer.

@shipilev
Copy link
Member

shipilev commented Nov 12, 2021

/sponsor

@openjdk
Copy link

openjdk bot commented Nov 12, 2021

Going to push as commit 193c7f1.
Since your change was applied there have been 216 commits pushed to the master branch:

  • 3e349b4: 8276025: Hotspot's libsvml.so may conflict with user dependency
  • 58a6dae: 8275872: Sync J2DBench run and analyze Makefile targets with build.xml
  • 7aaad16: 8238649: Call new Win32 API SetThreadDescription in os::set_native_thread_name
  • 16a191c: 8261579: AArch64: Support for weaker memory ordering in Atomic
  • 89a03fe: 8273450: Fix the copyright header of SVML files
  • 6bb5494: 8276572: Fake libsyslookup.so library causes tooling issues
  • 4eeefb4: 8275666: serviceability/jvmti/GetObjectSizeClass.java shouldn't have vm.flagless
  • ed48774: 8274523: java/lang/management/MemoryMXBean/MemoryTest.java test should handle Shenandoah
  • acd939e: 8274522: java/lang/management/ManagementFactory/MXBeanException.java test fails with Shenandoah
  • 0b52b9d: 8276550: Use SHA256 hash in build.tools.depend.Depend
  • ... and 206 more: https://git.openjdk.java.net/jdk17u/compare/cef269f89633331a68c9549a08d2d88d5534b8fa...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Nov 12, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Nov 12, 2021
@openjdk
Copy link

openjdk bot commented Nov 12, 2021

@shipilev @snazarkin Pushed as commit 193c7f1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants