Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8274779: HttpURLConnection: HttpClient and HttpsClient incorrectly check request method when set to POST #212

Closed
wants to merge 1 commit into from

Conversation

evwhelan
Copy link
Contributor

@evwhelan evwhelan commented Oct 22, 2021

Hi,

Please review my clean backport of JDK-8274779.

No related test failures.

Thanks in advance,
Evan


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8274779: HttpURLConnection: HttpClient and HttpsClient incorrectly check request method when set to POST

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u pull/212/head:pull/212
$ git checkout pull/212

Update a local copy of the PR:
$ git checkout pull/212
$ git pull https://git.openjdk.java.net/jdk17u pull/212/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 212

View PR using the GUI difftool:
$ git pr show -t 212

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u/pull/212.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 22, 2021

👋 Welcome back ewhelan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 45ce06c9f3e9bee7d4bda313c38f0f0e8786a4db 8274779: HttpURLConnection: HttpClient and HttpsClient incorrectly check request method when set to POST Oct 22, 2021
@openjdk
Copy link

openjdk bot commented Oct 22, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Oct 22, 2021

@evwhelan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8274779: HttpURLConnection: HttpClient and HttpsClient incorrectly check request method when set to POST

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 22, 2021
@evwhelan
Copy link
Contributor Author

evwhelan commented Oct 22, 2021

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Oct 22, 2021
@openjdk
Copy link

openjdk bot commented Oct 22, 2021

@evwhelan
Your change (at version cf845b0) is now ready to be sponsored by a Committer.

@mlbridge
Copy link

mlbridge bot commented Oct 22, 2021

Webrevs

@coffeys
Copy link
Contributor

coffeys commented Oct 26, 2021

/sponsor

@openjdk
Copy link

openjdk bot commented Oct 26, 2021

Going to push as commit a1dc595.
Since your change was applied there have been 5 commits pushed to the master branch:

  • 80077e5: 8272305: several hotspot runtime/modules don't check exit codes
  • c7b9f9e: 8272391: Undeleted debug information
  • 15964f0: 8272335: runtime/cds/appcds/MoveJDKTest.java doesn't check exit codes
  • e85351d: 8271215: Fix data races in G1PeriodicGCTask
  • 031c033: 8275145: file.encoding system property has an incorrect value on Windows

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Oct 26, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Oct 26, 2021
@openjdk
Copy link

openjdk bot commented Oct 26, 2021

@coffeys @evwhelan Pushed as commit a1dc595.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants