Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8275145: file.encoding system property has an incorrect value on Windows #213

Closed
wants to merge 1 commit into from

Conversation

@naotoj
Copy link
Member

@naotoj naotoj commented Oct 22, 2021

This PR is for a backport of the subject fix to jdk17u. The fix for jdk18 was applied cleanly.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8275145: file.encoding system property has an incorrect value on Windows ⚠️ Issue is not open.

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u pull/213/head:pull/213
$ git checkout pull/213

Update a local copy of the PR:
$ git checkout pull/213
$ git pull https://git.openjdk.java.net/jdk17u pull/213/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 213

View PR using the GUI difftool:
$ git pr show -t 213

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u/pull/213.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 22, 2021

👋 Welcome back naoto! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Oct 22, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 22, 2021

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented Oct 22, 2021

@naotoj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8275145: file.encoding system property has an incorrect value on Windows

Reviewed-by: iris

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • 90273f3: 8251329: (zipfs) Files.walkFileTree walks infinitely if zip has dir named "." inside
  • 844d8bf: 8274205: Handle KDC_ERR_SVC_UNAVAILABLE error code from KDC
  • facbabb: 8270946: X509CertImpl.getFingerprint should not return the empty String

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Oct 22, 2021
@naotoj
Copy link
Member Author

@naotoj naotoj commented Oct 23, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Oct 23, 2021

Going to push as commit 031c033.
Since your change was applied there have been 3 commits pushed to the master branch:

  • 90273f3: 8251329: (zipfs) Files.walkFileTree walks infinitely if zip has dir named "." inside
  • 844d8bf: 8274205: Handle KDC_ERR_SVC_UNAVAILABLE error code from KDC
  • facbabb: 8270946: X509CertImpl.getFingerprint should not return the empty String

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Oct 23, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Oct 23, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 23, 2021

@naotoj Pushed as commit 031c033.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants