Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8275104: IR framework does not handle client VM builds correctly #214

Closed
wants to merge 1 commit into from

Conversation

@theaoqi
Copy link
Member

@theaoqi theaoqi commented Oct 26, 2021

The patch applies clean. Low risk, only test changes. The modified test passed on linux-x64. With this patch and backport of 8273965, all test/hotspot/jtreg/testlibrary_tests/ir_framework tests passed with and without compiler1.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8275104: IR framework does not handle client VM builds correctly

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u pull/214/head:pull/214
$ git checkout pull/214

Update a local copy of the PR:
$ git checkout pull/214
$ git pull https://git.openjdk.java.net/jdk17u pull/214/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 214

View PR using the GUI difftool:
$ git pr show -t 214

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u/pull/214.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 26, 2021

👋 Welcome back aoqi! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 1da5e6b0e2c284c5dd295a0d48cc1c6c2fecf5b5 8275104: IR framework does not handle client VM builds correctly Oct 26, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 26, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

@openjdk openjdk bot commented Oct 26, 2021

@theaoqi This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8275104: IR framework does not handle client VM builds correctly

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • ccfe697: 8190753: (zipfs): Accessing a large entry (> 2^31 bytes) leads to a negative initial size for ByteArrayOutputStream
  • a1dc595: 8274779: HttpURLConnection: HttpClient and HttpsClient incorrectly check request method when set to POST

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 26, 2021

Webrevs

@theaoqi
Copy link
Member Author

@theaoqi theaoqi commented Oct 26, 2021

jdk17u-fix-request had been approved. Could someone please sponsor this already approved backport?

/integrate

@openjdk openjdk bot added the sponsor label Oct 26, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 26, 2021

@theaoqi
Your change (at version ed1a89c) is now ready to be sponsored by a Committer.

@RealCLanger
Copy link
Contributor

@RealCLanger RealCLanger commented Oct 28, 2021

/sponsor

@openjdk
Copy link

@openjdk openjdk bot commented Oct 28, 2021

Going to push as commit 08cee6f.
Since your change was applied there have been 2 commits pushed to the master branch:

  • ccfe697: 8190753: (zipfs): Accessing a large entry (> 2^31 bytes) leads to a negative initial size for ByteArrayOutputStream
  • a1dc595: 8274779: HttpURLConnection: HttpClient and HttpsClient incorrectly check request method when set to POST

Your commit was automatically rebased without conflicts.

@openjdk
Copy link

@openjdk openjdk bot commented Oct 28, 2021

@RealCLanger @theaoqi Pushed as commit 08cee6f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants