-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8271567: AArch64: AES Galois CounterMode (GCM) interleaved implementation using vector instructions #216
Conversation
👋 Welcome back aph! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
@theRealAph This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 5 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
A small change: use the existing |
I believe that change was in when I reviewed this. So all is good. |
Can I get some maintainer attention for this one? Adds AES/GCM acceleration, very low risk because change because it's disabled by default. |
Hi @theRealAph , I also had a no risk backport to jdk11u openjdk/jdk11u-dev#599 . So may I ask the reason for the rejection? |
Absolutely you may, but you should ask in the right place, which is in the appropriate bug report. |
/integrate |
Going to push as commit 076941f.
Your commit was automatically rebased without conflicts. |
@theRealAph Pushed as commit 076941f. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
It's been nearly a year, can we consider enabling this by default now? |
I think so. Perhaps for 11 too. |
[New PR because of the 17u updates SNAFU.]
This is a backport of the big AES/GCM patch from JDK head. It's a
major change and it's had very little time (almost a day) to mature in
head, so I've set things up so that there is no change at all unless
you explicitly enable
-XX:+UseAESGCMIntrinsics
, which defaultsto false. When we've had more time we can perhaps turn it on by default.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u pull/216/head:pull/216
$ git checkout pull/216
Update a local copy of the PR:
$ git checkout pull/216
$ git pull https://git.openjdk.java.net/jdk17u pull/216/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 216
View PR using the GUI difftool:
$ git pr show -t 216
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u/pull/216.diff