-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8276130: Fix Github Actions of JDK17u to account for update version scheme #218
Conversation
👋 Welcome back clanger! A progress list of the required criteria for merging this PR into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems straightforward, and you tested it, right?
Could this be broken down into multiple lines? (no problem if not, change is fine as it is).
Cheers, Thomas
@RealCLanger This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 4 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
Thanks for the review. Yes, it's tested & working - you can see it in this PR or here: https://github.com/RealCLanger/jdk17u/actions/runs/1394411607 There's no currently open PR in here where GHA was configured and you could see the error. But, for comparison, a currently failing run can be seen in the SapMachine repository: https://github.com/SAP/SapMachine/actions/runs/1397068578 I'm matching the code of jdk11u with this PR. I agree it would probably be nicer to break the lines but I would do it in a separate PR and backport it to 11 as well. |
/integrate |
Going to push as commit 25bfea6.
Your commit was automatically rebased without conflicts. |
@RealCLanger Pushed as commit 25bfea6. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
With the release of 17.0.1, the version number of jdk17u now does not only contain the feature part but also interim and update. This fix will unbreak github actions.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u pull/218/head:pull/218
$ git checkout pull/218
Update a local copy of the PR:
$ git checkout pull/218
$ git pull https://git.openjdk.java.net/jdk17u pull/218/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 218
View PR using the GUI difftool:
$ git pr show -t 218
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u/pull/218.diff