Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8273595: tools/jpackage tests do not work on apt-based Linux distros like Debian #219

Closed
wants to merge 2 commits into from

Conversation

theaoqi
Copy link
Member

@theaoqi theaoqi commented Oct 29, 2021

The patch applies clean. Low risk, only test changes. test/jdk/tools/jpackage tests passed on x64/Ubuntu and x64/Debian.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8273595: tools/jpackage tests do not work on apt-based Linux distros like Debian

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u pull/219/head:pull/219
$ git checkout pull/219

Update a local copy of the PR:
$ git checkout pull/219
$ git pull https://git.openjdk.java.net/jdk17u pull/219/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 219

View PR using the GUI difftool:
$ git pr show -t 219

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u/pull/219.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 29, 2021

👋 Welcome back aoqi! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport f189dff5cbd4d47e1b2f3c0e5f2c866a7effccdf 8273595: tools/jpackage tests do not work on apt-based Linux distros like Debian Oct 29, 2021
@openjdk
Copy link

openjdk bot commented Oct 29, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Oct 29, 2021

@theaoqi This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8273595: tools/jpackage tests do not work on apt-based Linux distros like Debian

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

  • 9ff9e62: 8271315: Redo: Nimbus JTree renderer properties persist across L&F changes
  • e7e83d5: 8272369: java/io/File/GetXSpace.java failed with "RuntimeException: java.nio.file.NoSuchFileException: /run/user/0"
  • 1d11bcd: 8273486: Zero: Handle DiagnoseSyncOnValueBasedClasses VM option
  • 95726bf: 8276105: C2: Conv(D|F)2(I|L)Nodes::Ideal should handle rounding correctly
  • 93d8337: 8276846: JDK-8273416 is incomplete for UseSSE=1

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 29, 2021
@mlbridge
Copy link

mlbridge bot commented Oct 29, 2021

Webrevs

@theaoqi
Copy link
Member Author

theaoqi commented Nov 1, 2021

jdk17u-fix-request had been approved. Could someone please sponsor this backport?

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Nov 1, 2021
@openjdk
Copy link

openjdk bot commented Nov 1, 2021

@theaoqi
Your change (at version 5a5b9a4) is now ready to be sponsored by a Committer.

@shipilev
Copy link
Member

@theaoqi Please reschedule the GHA runs, so they are provably green? Probably merge from jdk17u master too. Then I'll sponsor.

@openjdk openjdk bot removed the sponsor Pull request is ready to be sponsored label Nov 16, 2021
@theaoqi
Copy link
Member Author

theaoqi commented Nov 16, 2021

@shipilev, master has been merged. GHA tests are retriggered and passed. If I was doing correctly, please sponsor. Thanks!

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Nov 16, 2021
@openjdk
Copy link

openjdk bot commented Nov 16, 2021

@theaoqi
Your change (at version a3cd1d2) is now ready to be sponsored by a Committer.

@shipilev
Copy link
Member

You're good, thanks!

/integrate

@shipilev
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Nov 16, 2021

@shipilev Only the author (@theaoqi) is allowed to issue the integrate command. As this pull request is ready to be sponsored, and you are an eligible sponsor, did you mean to issue the /sponsor command?

@openjdk
Copy link

openjdk bot commented Nov 16, 2021

Going to push as commit e8eec1f.
Since your change was applied there have been 5 commits pushed to the master branch:

  • 9ff9e62: 8271315: Redo: Nimbus JTree renderer properties persist across L&F changes
  • e7e83d5: 8272369: java/io/File/GetXSpace.java failed with "RuntimeException: java.nio.file.NoSuchFileException: /run/user/0"
  • 1d11bcd: 8273486: Zero: Handle DiagnoseSyncOnValueBasedClasses VM option
  • 95726bf: 8276105: C2: Conv(D|F)2(I|L)Nodes::Ideal should handle rounding correctly
  • 93d8337: 8276846: JDK-8273416 is incomplete for UseSSE=1

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Nov 16, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Nov 16, 2021
@openjdk
Copy link

openjdk bot commented Nov 16, 2021

@shipilev @theaoqi Pushed as commit e8eec1f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@theaoqi
Copy link
Member Author

theaoqi commented Nov 16, 2021

Thanks again for the help, @shipilev.

@theaoqi theaoqi deleted the backport-8273595 branch Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants