Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8274848: LambdaMetaFactory::metafactory on REF_invokeSpecial impl method has incorrect behavior #221

Closed

Conversation

mlchung
Copy link
Member

@mlchung mlchung commented Oct 29, 2021

This pull request contains a backport of commit 21da2183 from the openjdk/jdk repository.

The commit being backported was authored by Mandy Chung on 28 Oct 2021 and was reviewed by Paul Sandoz and Dan Smith.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8274848: LambdaMetaFactory::metafactory on REF_invokeSpecial impl method has incorrect behavior

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u pull/221/head:pull/221
$ git checkout pull/221

Update a local copy of the PR:
$ git checkout pull/221
$ git pull https://git.openjdk.java.net/jdk17u pull/221/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 221

View PR using the GUI difftool:
$ git pr show -t 221

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u/pull/221.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 29, 2021

👋 Welcome back mchung! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@mlchung mlchung changed the title Backport of 8274848: LambdaMetaFactory::metafactory on REF_invokeSpecial impl method has incorrect behavior 8274848: LambdaMetaFactory::metafactory on REF_invokeSpecial impl method has incorrect behavior Oct 29, 2021
@openjdk openjdk bot added the rfr label Oct 29, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 29, 2021

Webrevs

@mlchung
Copy link
Member Author

@mlchung mlchung commented Nov 1, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Nov 1, 2021

@mlchung This pull request has not yet been marked as ready for integration.

@mlchung mlchung changed the title 8274848: LambdaMetaFactory::metafactory on REF_invokeSpecial impl method has incorrect behavior Backport 21da2183875feca3dbf4f1bd875b268a7fc8d560 Nov 1, 2021
@openjdk openjdk bot changed the title Backport 21da2183875feca3dbf4f1bd875b268a7fc8d560 8274848: LambdaMetaFactory::metafactory on REF_invokeSpecial impl method has incorrect behavior Nov 1, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Nov 1, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

@openjdk openjdk bot commented Nov 1, 2021

@mlchung This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8274848: LambdaMetaFactory::metafactory on REF_invokeSpecial impl method has incorrect behavior

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 583844a: 8275302: unexpected compiler error: cast, intersection types and sealed

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Nov 1, 2021
@mlchung
Copy link
Member Author

@mlchung mlchung commented Nov 1, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Nov 1, 2021

Going to push as commit a0899bf.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 583844a: 8275302: unexpected compiler error: cast, intersection types and sealed

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Nov 1, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Nov 1, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Nov 1, 2021

@mlchung Pushed as commit a0899bf.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated
1 participant