Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8273026: Slow LoginContext.login() on multi threading application #223

Closed
wants to merge 1 commit into from

Conversation

Larry-N
Copy link
Contributor

@Larry-N Larry-N commented Nov 1, 2021

Performance enchansement. Tested with tier-2 on macOS.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8273026: Slow LoginContext.login() on multi threading application

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u pull/223/head:pull/223
$ git checkout pull/223

Update a local copy of the PR:
$ git checkout pull/223
$ git pull https://git.openjdk.java.net/jdk17u pull/223/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 223

View PR using the GUI difftool:
$ git pr show -t 223

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u/pull/223.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 1, 2021

👋 Welcome back Larry-N! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport c0cda1db4fe74b86faa12136336bdf98c96758d2 8273026: Slow LoginContext.login() on multi threading application Nov 1, 2021
@openjdk
Copy link

openjdk bot commented Nov 1, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Nov 1, 2021

@Larry-N This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8273026: Slow LoginContext.login() on multi threading application

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 1, 2021
@mlbridge
Copy link

mlbridge bot commented Nov 1, 2021

Webrevs

@Larry-N
Copy link
Contributor Author

Larry-N commented Nov 1, 2021

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Nov 1, 2021
@openjdk
Copy link

openjdk bot commented Nov 1, 2021

@Larry-N
Your change (at version 39e5f5e) is now ready to be sponsored by a Committer.

@yan-too
Copy link

yan-too commented Nov 9, 2021

/sponsor

@openjdk
Copy link

openjdk bot commented Nov 9, 2021

Going to push as commit 143cc64.
Since your change was applied there have been 20 commits pushed to the master branch:

  • aadd484: 8271895: UnProblemList javax/swing/JComponent/7154030/bug7154030.java in JDK18
  • 43ae179: 8270533: AArch64: size_fits_all_mem_uses should return false if its output is a CAS
  • 7176520: 8276201: Shenandoah: Race results degenerated GC to enter wrong entry point
  • e829c85: 8273021: C2: Improve Add and Xor ideal optimizations
  • dc93934: 8270901: Typo PHASE_CPP in CompilerPhaseType
  • 6c86a41: 8274338: com/sun/jdi/RedefineCrossEvent.java failed "assert(m != __null) failed: NULL mirror"
  • e160532: 8272345: macos doesn't check os::set_boot_path() result
  • 6d63a86: 8272114: Unused _last_state in osThread_windows
  • a384377: 8268626: Remove native pre-jdk9 support for jtreg failure handler
  • 9a2c123: 4819544: SwingSet2 JTable Demo throws NullPointerException
  • ... and 10 more: https://git.openjdk.java.net/jdk17u/compare/583844a4b2559fb91d3aa73f7310c4fbf46e5837...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Nov 9, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Nov 9, 2021
@openjdk
Copy link

openjdk bot commented Nov 9, 2021

@yan-too @Larry-N Pushed as commit 143cc64.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants