8270533: AArch64: size_fits_all_mem_uses should return false if its output is a CAS

[apavlyutkin]

I'd like to backport JDK-8190753 to jdk17u

The fix prevents using an output of Shift-n-Add operation as an input for CAS operation that takes only register operands for Aarch64

The original patch applied cleanly

Testing: original patch does not have verification tests. Regression: arm64 / 20.04 LTS / hotspot_all (with gtests)

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8270533: AArch64: size_fits_all_mem_uses should return false if its output is a CAS

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u pull/224/head:pull/224
$ git checkout pull/224

Update a local copy of the PR:
$ git checkout pull/224
$ git pull https://git.openjdk.java.net/jdk17u pull/224/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 224

View PR using the GUI difftool:
$ git pr show -t 224

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u/pull/224.diff

[bridgekeeper]

👋 Welcome back apavlyutkin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

@apavlyutkin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8270533: AArch64: size_fits_all_mem_uses should return false if its output is a CAS

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 17 new commits pushed to the master branch:

• e829c85: 8273021: C2: Improve Add and Xor ideal optimizations
• dc93934: 8270901: Typo PHASE_CPP in CompilerPhaseType
• 6c86a41: 8274338: com/sun/jdi/RedefineCrossEvent.java failed "assert(m != __null) failed: NULL mirror"
• e160532: 8272345: macos doesn't check os::set_boot_path() result
• 6d63a86: 8272114: Unused _last_state in osThread_windows
• a384377: 8268626: Remove native pre-jdk9 support for jtreg failure handler
• 9a2c123: 4819544: SwingSet2 JTable Demo throws NullPointerException
• 0ab99ed: 8268457: XML Transformer outputs Unicode supplementary character incorrectly to HTML
• a834b58: 8269269: [macos11] SystemIconTest fails with ClassCastException
• 23326d5: 8266510: Nimbus JTree default tree cell renderer does not use selected text color
• ... and 7 more: https://git.openjdk.java.net/jdk17u/compare/583844a4b2559fb91d3aa73f7310c4fbf46e5837...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[mlbridge]

Webrevs

• 00: Full (d4c68c28)

[apavlyutkin]

/integrate

[openjdk]

@apavlyutkin
Your change (at version d4c68c2) is now ready to be sponsored by a Committer.

[yan-too]

/sponsor

[openjdk]

Going to push as commit 43ae179.
Since your change was applied there have been 18 commits pushed to the master branch:

• 7176520: 8276201: Shenandoah: Race results degenerated GC to enter wrong entry point
• e829c85: 8273021: C2: Improve Add and Xor ideal optimizations
• dc93934: 8270901: Typo PHASE_CPP in CompilerPhaseType
• 6c86a41: 8274338: com/sun/jdi/RedefineCrossEvent.java failed "assert(m != __null) failed: NULL mirror"
• e160532: 8272345: macos doesn't check os::set_boot_path() result
• 6d63a86: 8272114: Unused _last_state in osThread_windows
• a384377: 8268626: Remove native pre-jdk9 support for jtreg failure handler
• 9a2c123: 4819544: SwingSet2 JTable Demo throws NullPointerException
• 0ab99ed: 8268457: XML Transformer outputs Unicode supplementary character incorrectly to HTML
• a834b58: 8269269: [macos11] SystemIconTest fails with ClassCastException
• ... and 8 more: https://git.openjdk.java.net/jdk17u/compare/583844a4b2559fb91d3aa73f7310c4fbf46e5837...master

Your commit was automatically rebased without conflicts.

[openjdk]

@yan-too @apavlyutkin Pushed as commit 43ae179.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.